----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42651/#review116354 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java (line 147) <https://reviews.apache.org/r/42651/#comment177399> Indentation. This will fail in checkStyle falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java (line 62) <https://reviews.apache.org/r/42651/#comment177401> null check on output is missing. falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java (line 63) <https://reviews.apache.org/r/42651/#comment177402> Java doc should have parameters definition. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java (line 185) <https://reviews.apache.org/r/42651/#comment177400> This check can be added to all the test cases in thsi class. - PRAGYA MITTAL On Jan. 22, 2016, 1:04 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42651/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 1:04 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1766 > https://issues.apache.org/jira/browse/FALCON-1766 > > > Repository: falcon-git > > > Description > ------- > > Add code to check CLI metrics for both HiveDR recipe based process as well as > for feed replication. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java > 2e6fca9 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > e406cae > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java > 9d3b802 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > 6728edf > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java > 7660e04 > > falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml > 72d40a3 > > Diff: https://reviews.apache.org/r/42651/diff/ > > > Testing > ------- > > Tested > > > Thanks, > > Paul Isaychuk > >
