> On Jan. 28, 2016, 12:01 p.m., Praveen Adlakha wrote: > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java, > > line 74 > > <https://reviews.apache.org/r/42855/diff/1/?file=1224655#file1224655line74> > > > > cool...One more command that works on prism is submitAndSchedule will > > add for that too..Will wait for your response before making any changes > > also please let me know why this approach is bad. > > Ajay Yadava wrote: > I actually like this approach, Only thing I would like to be improved is > to send Forbidden (HTTP Status code-403) > > Deepak Barr wrote: > 403 is more about access and permission I feel. We can think of HTTP 501 > or 405 instead.
It is exactly about permission. You are not allowed to call delete on server, but prism is allowed to call it. Since the method is implemented but you are not allowed to use it, you shouldn't return 501. Similarly the common use case for 405 is when a particular method is not allowed on that resource e.g. GET instead of POST, which is not the case either. So 403 seems better to me. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42855/#review116759 ----------------------------------------------------------- On Jan. 28, 2016, 7:04 a.m., Praveen Adlakha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42855/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 7:04 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1774 > https://issues.apache.org/jira/browse/FALCON-1774 > > > Repository: falcon-git > > > Description > ------- > > Error message when we hit falcon server in place of prism > > > Diffs > ----- > > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > afa2b6f > > Diff: https://reviews.apache.org/r/42855/diff/ > > > Testing > ------- > > $ bin/falcon entity -type process -name process1 -delete > Delete on server is not supported.Please run your operation on Prism. > > > Thanks, > > Praveen Adlakha > >
