Looks like the email per review comment is not yet disabled, I am following up with INFRA, sorry for the inconvenience.
On Fri, Jan 29, 2016 at 12:21 PM, Pallavi Rao <[email protected]> wrote: > Thanks Ajay for enabling this! Simplifies the whole patch upload, review, > commit process. > > Will start using right away :-). > > On Fri, Jan 29, 2016 at 11:09 AM, Ajay Yadava <[email protected]> > wrote: > >> Hello everyone, >> >> Good news!! Github integration is complete and ready for use. As part of >> this some more good stuff got done. >> >> 1. A new tool to merge pull requests has been created. It *squashes >> commits*, *reformats the commit messages in standard format*, *adds >> reviewers, retains original contributor as author of the commit *etc. >> Usage guide has been made available on wiki >> >> <https://cwiki.apache.org/confluence/display/FALCON/How+to+merge+pull+requests> >> . >> 2. New merge tool also automates the closure of the relevant JIRA >> with fix version. >> 3. A pre commit build has also been configured. No more testing >> patches on your local box. >> 4. How to Contribute guide >> <https://cwiki.apache.org/confluence/display/FALCON/How+To+Contribute> has >> been updated with several new sections for non code contributions and >> github pull request model. >> 5. README file has been updated. It now parses markdown syntax(looks >> lot better in github now) and contains the link to how to contribute >> guide, >> change log etc. >> >> *How it works?* >> With the new integration in place, whenever a new pull request is >> created, a pre commit build will be automatically triggered and result will >> be displayed along with the "conflict status"(see attachment). >> >> Also every time a pull request *which contains JIRA id* is created asf >> bot puts these details in the corresponding JIRA. See FALCON-1770 >> <https://issues.apache.org/jira/browse/FALCON-1770> for an example. >> >> To avoid noise on the mailing list we have disabled the emails whenever a >> comment is made on the pull request. You should watch the repository and >> use github notifications to see all updates. >> >> *Key things to take care of for pull requests*: >> >> - Mention JIRA id in your pull request see this pr >> <https://github.com/apache/falcon/pull/13>for reference >> - Don't forget to update the CHANGES.txt >> - You *don't need* to squash commit messages, but please make >> meaningful commit messages for each update. >> >> >> I will recommend all contributors to start using the new pull request >> method so that they are reflected as the author of their contributions in >> the github/git. >> >> *[image: Screen Shot 2016-01-23 at 11.45.02 PM.png]* >> >> Cheers >> Ajay Yadava >> > > > _____________________________________________________________ > The information contained in this communication is intended solely for the > use of the individual or entity to whom it is addressed and others > authorized to receive it. It may contain confidential or legally privileged > information. If you are not the intended recipient you are hereby notified > that any disclosure, copying, distribution or taking any action in reliance > on the contents of this information is strictly prohibited and may be > unlawful. If you have received this communication in error, please notify > us immediately by responding to this email and then delete it from your > system. The firm is neither liable for the proper and complete transmission > of the information contained in this communication nor for any delay in its > receipt.
