> On Jan. 27, 2016, 4:47 p.m., Peeyush Bishnoi wrote:
> > common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java, line 
> > 134
> > <https://reviews.apache.org/r/42642/diff/1/?file=1205293#file1205293line134>
> >
> >     Can actualPasswd be null or empty. If yes, how it is handled either by 
> > logging or throwing exception etc.

You can give an empty password text in the XML or jceks alias (but not null). 
The connection should work with empty password.


- Venkatesan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42642/#review116590
-----------------------------------------------------------


On Jan. 22, 2016, 3:27 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42642/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:27 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support password alias for database import and export using java keystore
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/datasource-0.1.xsd beb82cc 
>   common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java 1f1a193 
>   
> common/src/main/java/org/apache/falcon/entity/parser/DatasourceEntityParser.java
>  e58b1e9 
>   
> common/src/main/java/org/apache/falcon/security/CredentialProviderHelper.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 786ffea 
>   
> oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java
>  f1fb337 
>   
> oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java
>  19fa931 
>   webapp/src/test/java/org/apache/falcon/lifecycle/FeedImportIT.java 1fbad88 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java 
> 413dfde 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 321a5cf 
>   webapp/src/test/resources/datasource-template.xml fb7a329 
>   webapp/src/test/resources/datasource-template1.xml PRE-CREATION 
>   webapp/src/test/resources/datasource-template2.xml PRE-CREATION 
>   webapp/src/test/resources/feed-template3.xml a6c1d6b 
>   webapp/src/test/resources/feed-template4.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42642/diff/
> 
> 
> Testing
> -------
> 
> Unit tests and Manual end to end testing both on regular and secure cluster.
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>

Reply via email to