> On Feb. 4, 2016, 5:41 a.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java, > > line 172 > > <https://reviews.apache.org/r/42854/diff/1/?file=1223997#file1223997line172> > > > > Are the feeds getting deleted after the test passees? > > I have noticed so far that when we pass the names explicitly cleanUp > > does not handle deleting such entities. Please check once. > > Paul Isaychuk wrote: > Pragya, thanks for pointing this out. Actually clean up doen't depends on > how do we set the name implicitly or explicitly. It depende rather on what is > that name. > To be deleted, entity name should be of form like: <prefix> [entity name > itself]. Where prefix is either test class name or <'A'>+test class name hash > code (depending on is_deprecate property from Merlin.properties). > If entity name is something else, it wouldn't be removed. > > But seems that in case of > FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting > deleted not bacause of that. > As another user (root) is involved in test case (by submitting feed that > belongs to this another user), we don't see that feed in listing feeds as > test user (which is used by default to list and remove entities). Makes sense? > So we need to improve clean up logic. Do we need to create separate jira > for that? (it might be better then to squash it with new test) > > thanks.
Thanks Paul for explaining in detail. I had the same thought in mind but you expressed them better :) I have noticed this while I run nightly regression, a lot of entities are there which doesnot get clean up. Lets improve cleanup logic in a separate jira, but till that is not done please consider deleting the entity in this test case. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42854/#review117765 ----------------------------------------------------------- On Jan. 27, 2016, 3:53 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42854/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 3:53 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1784 > https://issues.apache.org/jira/browse/FALCON-1784 > > > Repository: falcon-git > > > Description > ------- > > Falcon-1647 fixes the following issue. > Create cluster entity as user1. Submit and schedule feed entity feed1 in this > cluster as user1. Now try to submit and schedule a feed entity feed2 in this > cluster as user2. This failed with error > > Permission denied: user=user2, access=WRITE, > inode="/apps/falcon/backupCluster/staging/falcon/workflows/feed":falcon:hdfs:drwxr-xr-x > > This issue was fixed by Falcon-1647 and we should have a regression test to > verify the fix. > > > Diffs > ----- > > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java > 46015dc > > Diff: https://reviews.apache.org/r/42854/diff/ > > > Testing > ------- > > Tested > > > Thanks, > > Paul Isaychuk > >
