[ 
https://issues.apache.org/jira/browse/FALCON-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134033#comment-15134033
 ] 

ASF GitHub Bot commented on FALCON-1819:
----------------------------------------

GitHub user pisaychuk opened a pull request:

    https://github.com/apache/falcon/pull/30

    FALCON-1819 Improve test class entity cleanup logic

    Improve entity clean up logic to handle entities belonging to different 
users.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pisaychuk/falcon master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 1f743ef68dc2641d4fbbd520012fe8bdd3b5ab59
Author: Paul Isaychuk <[email protected]>
Date:   2016-02-04T16:13:23Z

    FALCON-1819 Improve test class entity cleanup logic

----


> Improve test class entity cleanup logic
> ---------------------------------------
>
>                 Key: FALCON-1819
>                 URL: https://issues.apache.org/jira/browse/FALCON-1819
>             Project: Falcon
>          Issue Type: Bug
>          Components: merlin
>    Affects Versions: 0.7
>            Reporter: Paul Isaychuk
>            Assignee: Paul Isaychuk
>             Fix For: trunk
>
>
> From discussion with Pragya Mittal:
> To be deleted, entity name should be of form like: <prefix> \[entity name 
> itself\]. Where prefix is either test class name or <'A'>+test class name 
> hash code (depending on is_deprecate property from Merlin.properties).
> If entity name is something else, it wouldn't be removed.
> But seems that in case of 
> FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting 
> deleted not bacause of that. 
> As another user (root) is involved in test case (by submitting feed that 
> belongs to this another user), we don't see that feed in listing feeds as 
> test user (which is used by default to list and remove entities). Makes sense?
> So we need to improve clean up logic. Do we need to create separate jira for 
> that? (it might be better then to squash it with new test)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to