[
https://issues.apache.org/jira/browse/FALCON-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309155#comment-15309155
]
ASF GitHub Bot commented on FALCON-1984:
----------------------------------------
GitHub user yzheng-hortonworks opened a pull request:
https://github.com/apache/falcon/pull/166
FALCON-1984 Provide proper hint and documentation if required titan storage
backend is not configured in startup.properties
Added validation of required backend configuration properties.
Added error hints on the missing property in Falcon server log.
Reorganized the order of the configuration properties in startup.properties
so relevant properties for each backend are grouped in consecutive lines.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yzheng-hortonworks/falcon FALCON-1984
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/falcon/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit 423eacc98147c61efcbcae07a0a755cba0317322
Author: yzheng-hortonworks <[email protected]>
Date: 2016-05-27T23:54:19Z
FALCON-1984 Provide proper hint and documentation if required titan storage
backend is not configured in startup.properties
----
> Provide proper hint and documentation if required titan storage backend is
> not configured in startup.properties
> ---------------------------------------------------------------------------------------------------------------
>
> Key: FALCON-1984
> URL: https://issues.apache.org/jira/browse/FALCON-1984
> Project: Falcon
> Issue Type: Bug
> Reporter: Ying Zheng
> Assignee: Ying Zheng
>
> We require the user to choose either HBase or BDB as titan storage backend,
> which is not set by default in startup.properties. The current Falcon only
> shows the following error in the log if the user doesn't configure the
> storage backend and start falcon with default startup.properties. This is not
> intuitive for the user to understand the server start error. Should provide
> proper hint and documentation.
> {code}
> 2016-05-26 02:24:07,419 ERROR - [main:] ~ Failed to initialize service
> org.apache.falcon.metadata.MetadataMappingService (ServiceInitializer:49)
> java.lang.RuntimeException: GraphFactory could not instantiate this Graph
> implementation [com.thinkaurelius.titan.core.TitanFactory].
> at com.tinkerpop.blueprints.GraphFactory.open(GraphFactory.java:50)
> at
> org.apache.falcon.metadata.MetadataMappingService.initializeGraphDB(MetadataMappingService.java:123)
> at
> org.apache.falcon.metadata.MetadataMappingService.init(MetadataMappingService.java:90)
> at
> org.apache.falcon.service.ServiceInitializer.initialize(ServiceInitializer.java:47)
> at
> org.apache.falcon.listener.ContextStartupListener.contextInitialized(ContextStartupListener.java:56)
> at
> org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:550)
> at org.mortbay.jetty.servlet.Context.startContext(Context.java:136)
> at
> org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
> at
> org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:519)
> at
> org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
> at
> org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
> at
> org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
> at org.mortbay.jetty.Server.doStart(Server.java:224)
> at
> org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
> at org.apache.falcon.util.EmbeddedServer.start(EmbeddedServer.java:57)
> at org.apache.falcon.FalconServer.main(FalconServer.java:118)
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at com.tinkerpop.blueprints.GraphFactory.open(GraphFactory.java:45)
> ... 15 more
> Caused by: java.lang.IllegalStateException: Need to set configuration value:
> root.storage.backend
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:172)
> at
> com.thinkaurelius.titan.diskstorage.configuration.ConfigOption.get(ConfigOption.java:158)
> at
> com.thinkaurelius.titan.diskstorage.configuration.BasicConfiguration.get(BasicConfiguration.java:56)
> at
> com.thinkaurelius.titan.diskstorage.Backend.getStorageManager(Backend.java:361)
> at
> com.thinkaurelius.titan.graphdb.configuration.GraphDatabaseConfiguration.<init>(GraphDatabaseConfiguration.java:1275)
> at com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:93)
> at com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:73)
> ... 20 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)