[
https://issues.apache.org/jira/browse/FALCON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419506#comment-15419506
]
ASF GitHub Bot commented on FALCON-2115:
----------------------------------------
GitHub user yzheng-hortonworks opened a pull request:
https://github.com/apache/falcon/pull/262
FALCON-2115 UT test failure on FalconCSRFFilterTest
Need to add the property falcon.security.csrf.header to startup properties
when testing custom header for CSRF filter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yzheng-hortonworks/falcon FALCON-2115
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/falcon/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 612e600b7cd5fa7de2328155592e878e486ea51c
Author: yzheng-hortonworks <[email protected]>
Date: 2016-08-12T20:58:59Z
FALCON-2115 UT test failure on FalconCSRFFilterTest
----
> UT test failure on FalconCSRFFilterTest
> ---------------------------------------
>
> Key: FALCON-2115
> URL: https://issues.apache.org/jira/browse/FALCON-2115
> Project: Falcon
> Issue Type: Bug
> Reporter: Ying Zheng
> Assignee: Ying Zheng
>
> Need to add the property falcon.security.csrf.header to startup properties
> when testing custom header for CSRF filter.
> Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 1.186 sec <<<
> FAILURE! - in org.apache.falcon.security.FalconCSRFFilterTest
> testCSRFEnabledIncludeCustomHeaderFromBrowser(org.apache.falcon.security.FalconCSRFFilterTest)
> Time elapsed: 0.012 sec <<< FAILURE!
> org.mockito.exceptions.verification.NeverWantedButInvoked:
> mockResponse.sendError(
> 403,
> "Missing Required Header for CSRF Vulnerability Protection"
> );
> Never wanted here:
> -> at
> org.apache.falcon.security.FalconCSRFFilterTest.testCSRFEnabledIncludeCustomHeaderFromBrowser(FalconCSRFFilterTest.java:83)
> But invoked here:
> -> at
> org.apache.falcon.security.RestCsrfPreventionFilter$ServletFilterHttpInteraction.sendError(RestCsrfPreventionFilter.java:173)
> at
> org.apache.falcon.security.FalconCSRFFilterTest.testCSRFEnabledIncludeCustomHeaderFromBrowser(FalconCSRFFilterTest.java:83)
> testCSRFEnabledNoCustomHeaderFromBrowser(org.apache.falcon.security.FalconCSRFFilterTest)
> Time elapsed: 0.003 sec <<< FAILURE!
> org.mockito.exceptions.verification.TooManyActualInvocations:
> mockResponse.sendError(
> 403,
> "Missing Required Header for CSRF Vulnerability Protection"
> );
> Wanted 1 time:
> -> at
> org.apache.falcon.security.FalconCSRFFilterTest.testCSRFEnabledNoCustomHeaderFromBrowser(FalconCSRFFilterTest.java:73)
> But was 2 times. Undesired invocation:
> -> at
> org.apache.falcon.security.RestCsrfPreventionFilter$ServletFilterHttpInteraction.sendError(RestCsrfPreventionFilter.java:173)
> at
> org.apache.falcon.security.FalconCSRFFilterTest.testCSRFEnabledNoCustomHeaderFromBrowser(FalconCSRFFilterTest.java:73)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
