[jira] [Commented] (FALCON-2267) Definition api fails if resources are empty

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FALCON-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849703#comment-15849703
 ] 

ASF GitHub Bot commented on FALCON-2267:
----------------------------------------

GitHub user pallavi-rao opened a pull request:

    https://github.com/apache/falcon/pull/356

    FALCON-2267 Definition api fails if resources are empty

    Dev testing done:
    `IM1738M1:falcon-0.11-SNAPSHOT pallavi.rao$ bin/falcon extension -enumerate
    [
      {
        "name": "sample",
        "type": "Custom extension",
        "location": 
"hdfs://192.168.138.236:8020/tmp/extensions/extension-example"
      },
      …..
      {
        "name": "hive-mirroring",
        "type": "Trusted extension",
        "description": "This extension implements replicating hive metadata and 
data from one Hadoop cluster to another Hadoop cluster.",
        "location": 
"file:/Users/pallavi.rao/falcon/falcon-0.11-SNAPSHOT/extensions/hive-mirroring"
      }
    ]
    IM1738M1:falcon-0.11-SNAPSHOT pallavi.rao$ bin/falcon extension -definition 
-extensionName hive-mirroring
    
    {
        "shortDescription":"This extension implements replicating hive metadata 
and data from one Hadoop cluster to another Hadoop cluster.",
        "properties":[
            {
                "propertyName":"jobName",
                "required":true,
                "description":"Unique job name",
                "example":"hive-monthly-sales-dr"
            },
    ….
        ]
    }
    IM1738M1:falcon-0.11-SNAPSHOT pallavi.rao$ bin/falcon extension -definition 
-extensionName sample
    Contents of file config:
    
     
    Contents of file config2:
    <workflow-app xmlns="uri:oozie:workflow:0.1" name="merlin-workflow">
     ….
    
     
    
    IM1738M1:falcon-0.11-SNAPSHOT pallavi.rao$ bin/falcon extension -describe 
-extensionName sample
    Extension Test
    
    IM1738M1:falcon-0.11-SNAPSHOT pallavi.rao$ bin/falcon extension -describe 
-extensionName hive-mirroring
    # Licensed to the Apache Software Foundation (ASF) under one
    # or more contributor license agreements.  See the NOTICE file
    # distributed with this work for additional information
    # regarding copyright ownership.  The ASF licenses this file
    # to you under the Apache License, Version 2.0 (the
    # "License"); you may not use this file except in compliance
    # with the License.  You may obtain a copy of the License at
    #
    #     http://www.apache.org/licenses/LICENSE-2.0
    #
    # Unless required by applicable law or agreed to in writing, software
    # distributed under the License is distributed on an "AS IS" BASIS,
    # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    # See the License for the specific language governing permissions and
    # limitations under the License.
    
    Hive Mirroring Extension
    
    Overview
    Falcon provides feature to replicate Hive metadata and data events from 
source cluster to destination cluster.
    …..`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pallavi-rao/falcon 2267

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #356
    
----
commit f8d67b2dcbae9dc628973abbccdae2d5cbed243b
Author: Pallavi Rao <pallavi....@inmobi.com>
Date:   2017-02-02T09:16:59Z

    FALCON-2267 Definition api fails if resources are empty

----


> Definition api fails if resources are empty
> -------------------------------------------
>
>                 Key: FALCON-2267
>                 URL: https://issues.apache.org/jira/browse/FALCON-2267
>             Project: Falcon
>          Issue Type: Bug
>          Components: extensions
>    Affects Versions: trunk
>            Reporter: Pragya Mittal
>
> {noformat}
> pragya.mittal@falcon1001:~$ falcon extension -definition -extensionName 
> extension-example
> ERROR: Bad Request;Resource path cannot be null or empty
> {noformat}
> Hadoop path is :
> {noformat}
> pragya.mittal@falcon1001:~$ hl -R /tmp/extensions/extension-example
> /tmp/extensions/extension-example/META
> /tmp/extensions/extension-example/META/config
> /tmp/extensions/extension-example/README
> /tmp/extensions/extension-example/libs
> /tmp/extensions/extension-example/libs/build
> /tmp/extensions/extension-example/libs/build/falcon-extensions-0.11-SNAPSHOT-tests.jar
> /tmp/extensions/extension-example/libs/runtime
> /tmp/extensions/extension-example/resources
> /tmp/extensions/extension-example/resources/build
> /tmp/extensions/extension-example/resources/runtime
> {noformat}
> Extension is :
> {noformat}
> {
>    "name": "extension-example",
>    "type": "Custom extension",
>    "location": "hdfs://192.168.138.236:8020/tmp/extensions/extension-example"
>  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)