[
https://issues.apache.org/jira/browse/FALCON-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766829#comment-13766829
]
Srikanth Sundarrajan edited comment on FALCON-63 at 9/13/13 7:11 PM:
---------------------------------------------------------------------
When using set -e, it is important to consider cases where there is a
possibility of a non-zero exit code from a command is not considered a failure.
{code}
+HADOOPDIR=`which hadoop`
should actually be
+true || HADOOPDIR=`which hadoop`
{code}
Accidentally reopened the JIRA, it might be better to close this and open a
separate one as [~sureshms] has suggested.
The reason why set -e is perhaps done is to avoid checking return status of
each command which could potentially be an abort condition. If there are fewer
such statements, we should avoid using set -e. In this particular case for
service-start.sh, set -e seems unnecessary.
was (Author: sriksun):
When using set -e, it is important to consider cases where there is a
possibility of a non-zero exit code from a command is not considered a failure.
{code}
+HADOOPDIR=`which hadoop`
should actually be
+true || HADOOPDIR=`which hadoop`
{code}
Accidentally reopened the JIRA, it might be better to close this in a separate
one.
The reason why set -e is perhaps done is to avoid checking return status of
each command which could potentially be an abort condition. If there are fewer
such statements, we should avoid using set -e. In this particular case for
service-start.sh, set -e seems unnecessary.
> Ability to ingest hadoop libs to falcon release package
> -------------------------------------------------------
>
> Key: FALCON-63
> URL: https://issues.apache.org/jira/browse/FALCON-63
> Project: Falcon
> Issue Type: Sub-task
> Reporter: Shwetha G S
> Assignee: Suhas Vasu
> Fix For: 0.4
>
> Attachments: FALCON-63.patch, FALCON-63-v2.patch, FALCON-63-v3.patch,
> FALCON-63-v4.patch, FALCON-63-v5.patch, FALCON-63-v6.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
