[ 
https://issues.apache.org/jira/browse/FALCON-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806554#comment-13806554
 ] 

Srikanth Sundarrajan commented on FALCON-154:
---------------------------------------------

Following comment was intentionally added because the startup listener uses 
reflection to avoid different code base for hadoop-1 & 2. The comment was to 
provide a quick summary of what was being done in the code. Can you please 
retain them. Patch looks good otherwise.
{code}
@@ -79,10 +77,6 @@ public class HadoopStartupListener implements 
ServletContextListener {
         DataNode.createDataNode(emptyArgs, conf);
 
         JobConf jobConf = new JobConf(conf);
-        // JobTracker jt = JobTracker.startTracker(jobConf);
-        // jt.offerService();
-        // TaskTracker tt = new TaskTracker(jobConf);
-        // tt.run();
 
         Object jt = Class.forName("org.apache.hadoop.mapred.JobTracker")
                         .getMethod("startTracker", JobConf.class).invoke(null, 
jobConf);
@@ -95,15 +89,6 @@ public class HadoopStartupListener implements 
ServletContextListener {
 
     private void startHadoop2Services(Configuration conf, String[] emptyArgs) 
throws Exception {
 
-        // DefaultMetricsSystem.setMiniClusterMode(true);
-        // ResourceManager resourceManager = new ResourceManager(new 
MemStore());
-        // YarnConfiguration yarnConf = new YarnConfiguration(conf);
-        // resourceManager.init(yarnConf);
-        // resourceManager.start();
-        // NodeManager nodeManager = new NodeManager();
-        // nodeManager.init(yarnConf);
-        // nodeManager.start();
-
{code}

> Remove webhcat startup in HadoopStartupListener as its not used
> ---------------------------------------------------------------
>
>                 Key: FALCON-154
>                 URL: https://issues.apache.org/jira/browse/FALCON-154
>             Project: Falcon
>          Issue Type: Sub-task
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>         Attachments: FALCON-154.patch
>
>
> [~ashishujjain] brought to my attention that falcon does not compile against 
> hive-0.12 as webhcat has changed the package from o.a.hcatalog to 
> o.a.hive.hcatalog. Everything else has preserved the namespace but webhcat. 
> Since I abandoned using webhcat for java-api, having this does not make sense.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to