[
https://issues.apache.org/jira/browse/FALCON-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874658#comment-13874658
]
Shaik Idris Ali commented on FALCON-268:
----------------------------------------
"If we remove System.exit() from CLI status, the script can't check the return
code so it will return 0 (success) even if it's not really a success.
"
Why not just throw a new exception from
if (status != 200) {
ERR.get().println(
"Falcon server is not fully operational (on " +
falconUrl + "). Please check log files.");
throw new ........
}
and handle the exception in run method with appropriate return code.
This will be consistent with the existing conditions.
like:
catch (ClientHandlerException ex) {
ERR.get().print("Unable to connect to Falcon server, "
+ "please check if the URL is correct and Falcon server is
up and running\n");
ERR.get().println(ex.getMessage());
return -1;
}
> Checkstyle/Findbugs issues on FalconCLI
> ---------------------------------------
>
> Key: FALCON-268
> URL: https://issues.apache.org/jira/browse/FALCON-268
> Project: Falcon
> Issue Type: Bug
> Components: client
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Attachments: FALCON-268.patch
>
>
> Falcon doesn't build due to a checkstyle issue on FalconCLI.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
