[
https://issues.apache.org/jira/browse/FALCON-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875823#comment-13875823
]
Venkatesh Seetharam commented on FALCON-229:
--------------------------------------------
Thanks [~sriksun] for taking time to get this in. Patch looks very good
overall. Couple of concerns:
* EmbeddedServer has a factory method. Constructor for both Embedded and
Secure should be protected, no?
* SecureEmbeddedServer - overridden start and stop are not doing anything
different
* ChannelFactory - always instantiates SecureHTTPChannel. Should it not
check if TLS is enabled else construct HTTPChannel.
* Looks like TLS is enabled by default for integration tests and assembled
embedded mode. Is that intentional?
* I like the way its integrated into maven for generating keypair. Nice!
BTW, the patch does not apply cleanly over my security patches. I can either
rebase this or FALCON-18. No biggie.
> Enable SSL for Falcon REST API
> ------------------------------
>
> Key: FALCON-229
> URL: https://issues.apache.org/jira/browse/FALCON-229
> Project: Falcon
> Issue Type: Sub-task
> Affects Versions: 0.5
> Reporter: Venkatesh Seetharam
> Assignee: Srikanth Sundarrajan
> Labels: security
> Attachments: FALCON-229.patch
>
>
> Good to have but not in the first iteration.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
