> On Jan. 22, 2014, 12:53 a.m., Seetharam Venkatesh wrote: > > acquisition/pom.xml, line 34 > > <https://reviews.apache.org/r/17148/diff/1/?file=433490#file433490line34> > > > > Why is this necessary?
I moved the failsafe plugin to root pom to allow integration tests to be added to other modules besides webapp and the failsafe plugin requires either testng or junit dependency in every module. > On Jan. 22, 2014, 12:53 a.m., Seetharam Venkatesh wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 580 > > <https://reviews.apache.org/r/17148/diff/1/?file=433493#file433493line580> > > > > Isn't this useful for all calls? User wont see an exception if version > > call fails, no? This was findbug issue that was introduced recently where System.exit was added in there. I guess there is another JIRA which fixes this. Didn't want to include that in scope as @JB was already working on this. > On Jan. 22, 2014, 12:53 a.m., Seetharam Venkatesh wrote: > > hadoop-dependencies/pom.xml, line 83 > > <https://reviews.apache.org/r/17148/diff/1/?file=433497#file433497line83> > > > > What does this do? This is required to include version specific JT wrapper to the sources list and also include the required info for ServiceLoader to work. > On Jan. 22, 2014, 12:53 a.m., Seetharam Venkatesh wrote: > > hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java, > > line 29 > > <https://reviews.apache.org/r/17148/diff/1/?file=433499#file433499line29> > > > > Where is the class org.apache.falcon.JobTrackerService in the patch? > > Its missing. Sorry about that. Included revised patch with this class > On Jan. 22, 2014, 12:53 a.m., Seetharam Venkatesh wrote: > > hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java, > > line 64 > > <https://reviews.apache.org/r/17148/diff/1/?file=433499#file433499line64> > > > > Since you have done this much, why not extend it to hive metastore and > > start a local metastore instead of a remote one? > > All you need to do is to set hive.metastore.local to true and you are > > good to go. Else open a jira. I intend to do this in a separate JIRA. Will require some more time, dont want this large patch lingering with constant rebase. > On Jan. 22, 2014, 12:53 a.m., Seetharam Venkatesh wrote: > > hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java, > > line 126 > > <https://reviews.apache.org/r/17148/diff/1/?file=433499#file433499line126> > > > > Is there a local option for Broker. Question for Jean. :-) vm:// is what we are using in tests. Isn't that local enough ? - Srikanth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17148/#review32448 ----------------------------------------------------------- On Jan. 22, 2014, 2:58 a.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17148/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 2:58 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-123 > https://issues.apache.org/jira/browse/FALCON-123 > > > Repository: falcon-git > > > Description > ------- > > Currently default build includes javadocs generation, sources packaging, > checkstyle verification & findbugs verification besides whole lots of unit > tests and integration tests. It would be good to move some of these to > test-patch (verified by hudson) and during nightly builds. > > > Diffs > ----- > > acquisition/pom.xml e2017dd > archival/pom.xml c43e645 > build-tools/pom.xml 7a020d3 > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 01d2ced > common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java > 10a9cc0 > common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java > 6917472 > common/src/test/resources/runtime.properties PRE-CREATION > feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java > 128784e > hadoop-dependencies/pom.xml 225b9d9 > > hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java > PRE-CREATION > > hadoop-dependencies/src/main/services/org.apache.hadoop.mapreduce.protocol.ClientProtocolProvider > PRE-CREATION > > hadoop-dependencies/src/versioned-src/v2/java/org/apache/hadoop/mapred/ClassicClientProtocolProvider.java > PRE-CREATION > hadoop-webapp/pom.xml 7640883 > hadoop-webapp/src/main/java/org/apache/falcon/JobTrackerService.java > PRE-CREATION > > hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java > c2bb6f7 > hadoop-webapp/src/main/resources/core-site.xml 484e904 > hadoop-webapp/src/main/resources/hive-site.xml 49cda78 > hadoop-webapp/src/main/resources/yarn-site.xml 587f1c5 > hadoop-webapp/src/test/java/org/apache/hadoop/mapred/LocalRunnerTest.java > PRE-CREATION > > hadoop-webapp/src/versioned-src/v1/java/org/apache/hadoop/mapred/LocalRunnerV1.java > PRE-CREATION > > hadoop-webapp/src/versioned-src/v2/java/org/apache/hadoop/mapred/LocalRunnerV2.java > PRE-CREATION > messaging/pom.xml a59c1e3 > > messaging/src/test/java/org/apache/falcon/messaging/FalconTopicProducerTest.java > 27bea68 > messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java > a1609af > > messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java > 078b9c2 > metrics/pom.xml 1ed4f6b > oozie-el-extensions/pom.xml 4c76c89 > pom.xml 36c5f7a > > process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java > 794e585 > test-util/pom.xml 6bd4129 > test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java > c443e05 > test-util/src/main/resources/core-site.xml PRE-CREATION > webapp/pom.xml 0c2d844 > webapp/src/conf/oozie/conf/action-conf/hive.xml e5aef7d > webapp/src/conf/oozie/conf/hadoop-conf/core-site.xml 35078c7 > webapp/src/conf/oozie/conf/oozie-site.xml 48408ba > webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java > c4d6671 > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 4730728 > webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java > 9b672f4 > webapp/src/test/java/org/apache/falcon/logging/LogMoverIT.java e3cd914 > webapp/src/test/java/org/apache/falcon/logging/LogProviderIT.java 4c3ce97 > webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 58ae4ba > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > aa059bd > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > ac15391 > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 3fcd5dc > webapp/src/test/resources/cluster-template.xml 32eb643 > > Diff: https://reviews.apache.org/r/17148/diff/ > > > Testing > ------- > > > Thanks, > > Srikanth Sundarrajan > >
