[ 
https://issues.apache.org/jira/browse/FALCON-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878526#comment-13878526
 ] 

Shaik Idris Ali commented on FALCON-259:
----------------------------------------

I was trying to understand bigger picture, and here are few doubts/comments:

1. validate and compile are at primitive level, I thought the compilation is at 
project level, like a set of primitives or transforms tied together.
2.  Under message context is an object, using in toString make sense?
3. In validation,   error = true;
+                    break; I think its better we show all the error messages 
in a single compile.
4. doCompile is protected but all other are public?
5. Transform(List<RelationalData> inData, RelationalData outData), return type 
is single data, was wondering how partition will be implemented.
6.  public int hashCode() {
+        return version;
+    }
can be version.hashcode()?
7.In VersionedStoraged
 InputStream open(@Nonnull String namespace, @Nonnull String entity, int 
version) should'nt this be ?
 InputStream open(@Nonnull String namespace, @Nonnull String entity, Version 
version)




> Design Transformation Interface
> -------------------------------
>
>                 Key: FALCON-259
>                 URL: https://issues.apache.org/jira/browse/FALCON-259
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: designer
>    Affects Versions: 0.5
>            Reporter: Srikanth Sundarrajan
>            Assignee: Srikanth Sundarrajan
>         Attachments: FALCON-259.patch
>
>
> The foundation block in the pipeline designer is the transformation. All 
> primitives of the process are either defined as a transformation or an 
> action. Transformation is a data flow primitive while action could either be 
> a general purpose processing primitive or a control flow. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to