[ 
https://issues.apache.org/jira/browse/FALCON-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950476#comment-13950476
 ] 

Srikanth Sundarrajan commented on FALCON-352:
---------------------------------------------

{quote}
Instead of blocking the read threads during reload, we can use 
RuntimeProperties.get(). Create new instance of runtime properties and load the 
properties. After the load is complete, replace RuntimeProperties.INSTANCE. 
That should work?
{quote}
+1 for the approach.

{quote}
Another improvement: Currently, runtime properties is reloaded irrespective of 
if the properties file has changes. Can we reload only if the properties file 
has changed
{quote}
Please note that the properties are loading as a resource from CP, which means 
that you might not know the creation/modified time. If the resource url is a 
file, then we can perform the time check.


> old properties not removed on refresh of runtime properties 
> ------------------------------------------------------------
>
>                 Key: FALCON-352
>                 URL: https://issues.apache.org/jira/browse/FALCON-352
>             Project: Falcon
>          Issue Type: Bug
>    Affects Versions: 0.5
>         Environment: prod
>            Reporter: Samarth Gupta
>            Assignee: Shaik Idris Ali
>              Labels: commons
>         Attachments: FALCON-352.patch
>
>
> when runtime properties are refreshed at runtime the new modified changes are 
> added , however the old properties are not removed due to which prism can 
> keep sending request to deprecated servers. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to