----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21857/#review43925 -----------------------------------------------------------
Can you also change the default option of re-running only failed actions oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java <https://reviews.apache.org/r/21857/#comment78209> Function should return the params OozieUtils.toProperties probably iterates through conf and another for loop for iterating through properties. Can avoid one for loop prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java <https://reviews.apache.org/r/21857/#comment78210> rename function prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java <https://reviews.apache.org/r/21857/#comment78211> not required? prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java <https://reviews.apache.org/r/21857/#comment78212> rename - shwethags On May 26, 2014, 12:36 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21857/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 12:36 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Adding params option which will display all wf-params for a given instance > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0 > client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f > client/src/main/java/org/apache/falcon/resource/InstancesResult.java > da0ccc5 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > c28cb03 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 34192c0 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 3b87469 > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 42b4aeb > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > bdf5e1b > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27 > > Diff: https://reviews.apache.org/r/21857/diff/ > > > Testing > ------- > > > Thanks, > > pavan kumar kolamuri > >
