[ 
https://issues.apache.org/jira/browse/FALCON-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034787#comment-14034787
 ] 

Srikanth Sundarrajan commented on FALCON-369:
---------------------------------------------

[~shwethags], Looks like new patch has excluded newly added file. Can you 
please check ?

{code}
sriksun:incubator-falcon sriksun$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean
sriksun:incubator-falcon sriksun$ git pull
Already up-to-date.
sriksun:incubator-falcon sriksun$ curl 
"https://issues.apache.org/jira/secure/attachment/12650772/FALCON-369-v2.patch"; 
| git apply 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  318k  100  318k    0     0  86260      0  0:00:03  0:00:03 --:--:-- 86257
sriksun:incubator-falcon sriksun$ git status -s | egrep -v "^ M|^ D" 
sriksun:incubator-falcon sriksun$ 
{code}

> Refactor workflow builder
> -------------------------
>
>                 Key: FALCON-369
>                 URL: https://issues.apache.org/jira/browse/FALCON-369
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>         Attachments: FALCON-369-v2.patch, FALCON-369.patch, 
> FalconWorkflowBuilder.png
>
>
> Currently, feed/process workflow builder is a single class which handles all 
> different cases of lifecycles, storage types, workflow engines and building 
> all oozie entities(workflow, coord and bundle). This is not readable and 
> difficult to maintain. This needs some re-factoring.
> Approach:
> Maintain different builders for
> 1. oozie entities - workflow, coord and bundle. 
> 2. entity types - feed and process
> 3. lifecycle - process, retention and replication
> 4. workflow engines - oozie, pig and hive



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to