> On July 24, 2014, 9:33 a.m., Srikanth Sundarrajan wrote: > > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java, line 68 > > <https://reviews.apache.org/r/23844/diff/1/?file=640491#file640491line68> > > > > Why is coord func in generic entity builder ? Theoretically entity > > builder can be used to build bundle and this constant has no relevance > > there.
I was trying out something, but it's not required now. Will move it out > On July 24, 2014, 9:33 a.m., Srikanth Sundarrajan wrote: > > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java, line > > 171 > > <https://reviews.apache.org/r/23844/diff/1/?file=640491#file640491line171> > > > > Perhaps this is more appropriate for EntityUtil instead of > > EntityBuilder ? will move > On July 24, 2014, 9:33 a.m., Srikanth Sundarrajan wrote: > > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java, line > > 176 > > <https://reviews.apache.org/r/23844/diff/1/?file=640491#file640491line176> > > > > EntityUtil perhaps ? will move > On July 24, 2014, 9:33 a.m., Srikanth Sundarrajan wrote: > > oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java, > > line 134 > > <https://reviews.apache.org/r/23844/diff/1/?file=640492#file640492line134> > > > > Is the caller expected to retrieve items in order assuming first is > > success & next is failed. Seems a bit fragile. > > > > Does it make sense to pass a bunch of templates and return an action > > for each template in a map ? ordering is not expected > On July 24, 2014, 9:33 a.m., Srikanth Sundarrajan wrote: > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java, > > line 344 > > <https://reviews.apache.org/r/23844/diff/1/?file=640522#file640522line344> > > > > Can we add similar tests for retention & process as well ? OozieProcessWorkflowBuilderTest has process tests. OozieFeedWorkflowBuilderTest.java has both retention and replication > On July 24, 2014, 9:33 a.m., Srikanth Sundarrajan wrote: > > oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java, > > line 189 > > <https://reviews.apache.org/r/23844/diff/1/?file=640492#file640492line189> > > > > There is no reason to do this repeatedly since the action xml doesn't > > change across successive calls. Cache ? can be cached, will check - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23844/#review48638 ----------------------------------------------------------- On July 23, 2014, 11:36 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23844/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 11:36 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-481 > https://issues.apache.org/jira/browse/FALCON-481 > > > Repository: falcon-git > > > Description > ------- > > Currently, process parent workflow contains 2 decision nodes which take up > oozie processing and oozie db. The refactoring creates customised workflows > for fs/hcat, recordsize/without recordsize, pig/oozie/hive workflow engine > processes. It also defines pre-processing and post-processing actions only > once so that the definitions are consistent > > > Diffs > ----- > > oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java > 5f483f0 > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 1238b82 > > oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java > 2ef162b > > oozie/src/main/java/org/apache/falcon/oozie/feed/FSReplicationWorkflowBuilder.java > PRE-CREATION > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java > 0b582ef > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java > 2537725 > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java > ac38532 > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java > eee4fe9 > > oozie/src/main/java/org/apache/falcon/oozie/feed/HCatReplicationWorkflowBuilder.java > PRE-CREATION > > oozie/src/main/java/org/apache/falcon/oozie/process/HiveProcessWorkflowBuilder.java > 79a1883 > > oozie/src/main/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilder.java > 977d8c1 > > oozie/src/main/java/org/apache/falcon/oozie/process/PigProcessWorkflowBuilder.java > 29f601d > > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java > e46ae6e > > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java > 2e3a5c1 > oozie/src/main/java/org/apache/falcon/util/OozieUtils.java 9e1c82d > oozie/src/main/resources/workflow/falcon-table-export.hql 37fd1b7 > oozie/src/main/resources/workflow/falcon-table-import.hql 653d580 > oozie/src/main/resources/workflow/feed/falcon-table-export.hql PRE-CREATION > oozie/src/main/resources/workflow/feed/falcon-table-import.hql PRE-CREATION > oozie/src/main/resources/workflow/feed/fs-replication-workflow.xml > PRE-CREATION > oozie/src/main/resources/workflow/feed/hcat-replication-workflow.xml > PRE-CREATION > oozie/src/main/resources/workflow/feed/replication-action.xml PRE-CREATION > oozie/src/main/resources/workflow/feed/retention-workflow.xml PRE-CREATION > oozie/src/main/resources/workflow/post-process.xml PRE-CREATION > oozie/src/main/resources/workflow/pre-process.xml PRE-CREATION > oozie/src/main/resources/workflow/process-parent-workflow.xml 4a2495c > oozie/src/main/resources/workflow/process/hive-action.xml PRE-CREATION > oozie/src/main/resources/workflow/process/oozie-action.xml PRE-CREATION > oozie/src/main/resources/workflow/process/parent-workflow.xml PRE-CREATION > oozie/src/main/resources/workflow/process/pig-action.xml PRE-CREATION > oozie/src/main/resources/workflow/replication-workflow.xml 0748acf > oozie/src/main/resources/workflow/retention-workflow.xml 5138865 > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > c99c36c > oozie/src/test/java/org/apache/falcon/oozie/process/AbstractTestBase.java > cc0c419 > > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java > 3655af9 > src/main/examples/entity/hcat/hcat-out-feed.xml 26d1f18 > > Diff: https://reviews.apache.org/r/23844/diff/ > > > Testing > ------- > > UTs + end to end tests for fs usecases > > Pending: hcat testing > > > Thanks, > > shwethags > >
