[
https://issues.apache.org/jira/browse/FALCON-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094855#comment-14094855
]
Sowmya Ramesh commented on FALCON-470:
--------------------------------------
1. Please remove protected EntityList getEntityList in AbstractEntityManager
and call public method from tests
2. AbstractEntityManager line 504: configStore.get can return null. Can we do
null validation before accessing it?
3. Minor nit: In previous version entityTypeString = type.toLowerCase(). Can
you retain this behavior?
4. AbstractEntityManager.getStatusString : null check at 606 is redundant since
enum.name can never return null. Also please change the caught exception from
throwable to FalconException
5. nit: Lot of places you check the condition and then do ! e.g. Instead of if
(!(filterTagsList.size() == 0)) , please use != 0
6. nit: Few util methods can be made static and params final
7. AbstractEntityManager Line 623 can filterValue be null?
8. AbstractEntityManager : Move try IllegalArgumentException to line 638
9. Can you rename getReturnArrayLength to getRequiredNumberOfResults
10. FalconCLI: Validate methods ideally should be void methods doing validation
and shouldn't return any value. Can you please change it?
11. FalconClient : Why was import changed to *? Please import only required
classes.
Thanks!
> Add support for pagination to list API
> --------------------------------------
>
> Key: FALCON-470
> URL: https://issues.apache.org/jira/browse/FALCON-470
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.6
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Labels: rest_api
> Fix For: 0.6
>
> Attachments: Falcon-Jira-470-471-472-473-v1.patch,
> Falcon-Jira-470-471-472-473-v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
