> On Oct. 3, 2014, 4:18 a.m., Ruslan Ostafiychuk wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java, > > line 50 > > <https://reviews.apache.org/r/26110/diff/3/?file=709607#file709607line50> > > > > we can "return AssertUtil..." in try block and "return false;" once in > > last line of method
What value would that add ? - Raghav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26110/#review55333 ----------------------------------------------------------- On Sept. 30, 2014, 11 a.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26110/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11 a.m.) > > > Review request for Falcon. > > > Bugs: falcon-746 > https://issues.apache.org/jira/browse/falcon-746 > > > Repository: falcon-git > > > Description > ------- > > Add ACL validation and enforcement tests. > > > Diffs > ----- > > falcon-regression/README.md 659657c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java > 33b67f7 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > 025fc15 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > a10dfc1 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > eac3cb4 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > 3a56530 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java > ec8726c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java > d8ac903 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java > bf99291 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java > 1bbe8d9 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > 8fdf65a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26110/diff/ > > > Testing > ------- > > Adding new tests. > > > Thanks, > > Raghav Gautam > >
