> On Nov. 9, 2014, 3:06 p.m., Srikanth Sundarrajan wrote: > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java, > > line 117 > > <https://reviews.apache.org/r/26912/diff/3/?file=751521#file751521line117> > > > > Variable names are still slaStart/slaEnd. > > > > Looks like slaStart is validated only if slaEnd is populated. Are we > > proposing that slaStart has no significance unless slaEnd is not specified
These are only inner temporary variables. All the error messages and XML attributes have shouldStartIn and shouldEndIn. For inner temporary variables I tried to keep them small instead of shouldStartInExpression or shouldEndInExpression. If it looks confusing or inconsistent then please let me know and I will happily change it. The validation checks that slaStart is less than slaEnd and doesn't make sense if slaEnd is not there. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26912/#review60508 ----------------------------------------------------------- On Nov. 6, 2014, 9:31 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26912/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 9:31 a.m.) > > > Review request for Falcon and Srikanth Sundarrajan. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-722 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-722 > > > Repository: falcon-git > > > Description > ------- > > Add SLA for process. > > > Diffs > ----- > > client/src/main/resources/process-0.1.xsd 06a2fe4 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 9be4e85 > > common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java > 80a9cc7 > common/src/test/resources/config/process/process-0.1.xml 99a0376 > docs/src/site/twiki/EntitySpecification.twiki b0dfb7f > > Diff: https://reviews.apache.org/r/26912/diff/ > > > Testing > ------- > > Yes. All tests pass. > > > Thanks, > > Ajay Yadava > >
