> On Nov. 5, 2014, 1:25 a.m., Srikanth Sundarrajan wrote: > > common/src/main/java/org/apache/falcon/util/RadixNode.java, line 77 > > <https://reviews.apache.org/r/26908/diff/1/?file=725329#file725329line77> > > > > Please return an unmodifiableCollection > > Ajay Yadava wrote: > I am returning an unmodifiable collection from the implementation. > Collections.unmodifiableCollection returns a Collection. Are you suggesting > me to use UnmodifiableCollection interface from some other library like > commons?
Fixed it. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26908/#review59897 ----------------------------------------------------------- On Nov. 10, 2014, 3:18 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26908/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 3:18 p.m.) > > > Review request for Falcon and Srikanth Sundarrajan. > > > Repository: falcon-git > > > Description > ------- > > Store for feed path(key) and feed properties like feed name etc. as values > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/store/FeedLocationStore.java > PRE-CREATION > common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java > PRE-CREATION > common/src/main/java/org/apache/falcon/util/RadixNode.java PRE-CREATION > common/src/main/java/org/apache/falcon/util/RadixTree.java PRE-CREATION > > common/src/test/java/org/apache/falcon/entity/store/FeedLocationStoreTest.java > PRE-CREATION > common/src/test/java/org/apache/falcon/util/RadixNodeTest.java PRE-CREATION > common/src/test/java/org/apache/falcon/util/RadixTreeTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/26908/diff/ > > > Testing > ------- > > Thorough unit testing for the patch submitted. > > > Thanks, > > Ajay Yadava > >
