[
https://issues.apache.org/jira/browse/FELIX-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stuart McCulloch updated FELIX-261:
-----------------------------------
Attachment: FELIX-261-20070521-add-warning.patch
FELIX-261-20070521-add-warning.patch
Additional patch to address when both maven resources and Include-Resource are
specified in a pom.
It now outputs a warning to the log, and uses the Include-Resource setting -
this will let people override
the default and also allow them to see what they're overriding (in case they
need to update their setting
to include any of the default entries).
(patch also includes an update to the Felix.properties file which was
temporarily hard-coded in r539597)
> maven-bundle-plugin, Include-Resources directive and maven <resources/>
> -----------------------------------------------------------------------
>
> Key: FELIX-261
> URL: https://issues.apache.org/jira/browse/FELIX-261
> Project: Felix
> Issue Type: Improvement
> Components: Maven Bundle Plugin
> Reporter: Alin Dreghiciu
> Assigned To: Richard S. Hall
> Attachments: FELIX-261-20070413.patch, FELIX-261-20070517.patch,
> FELIX-261-20070521-add-warning.patch
>
>
> Currently maven-bundle-plugin handling of resources is hardcoded to the usgae
> of folder "src/main/resources".
> It should instead use the <resources/> folder setting from the pom.
> This is a followup of a discussion from felix mail list and bellow is a
> possible solution from Stuart McCulloch:
> I think you just need to iterate through the project resource list, for
> example:
> /*
> * I grant license to ASF for inclusion of the following code
> * in ASF works, as per the Apache Software License
> */
> StringBuilder resourcePaths = new StringBuilder();
> for (Iterator i = project.getResources().iterator(); i.hasNext();) {
> org.apache.maven.model.Resource resource =
> (org.apache.maven.model.Resource)i.next();
> if (new File(resource.getDirectory()).exists()) {
> String path = resource.getDirectory();
> String base = baseDir.getAbsolutePath();
> if (path.startsWith(base)) {
> path = path.substring(base.length() + 1);
> }
> if (resourcePaths.length() > 0) {
> resourcePaths.append(',');
> }
> resourcePaths.append(path);
> }
> }
> header(properties, Analyzer.INCLUDE_RESOURCE, resourcePaths);
> /*** warning: it hasn't been thoroughly tested! ***/
> There should also be a plugin option to turn off this code, just in case ;)
> Also should we be preserving the path layout in the bundle, which requires
> the PATH=PATH form of Include-Resource, or should we flatten resources?
> Perhaps add another plugin option...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
