On 22/05/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote:
Sure, I'll raise a JIRA and attach the patch. But if anyone has any idea of how the substitution occurs ...
from what I can tell, INSTALL_PATH is substituted by the izpack tool: http://svn.berlios.de/svnroot/repos/izpack/izpack-src/branches/3.10/src/lib/com/izforge/izpack/installer izpack supports various forms of variable substitution, including: $... %... ${...} %{...} INSTALL_PATH is one of the provided substitutions in izpack (for more see ScriptParser.java) this is just from a bit of googling, so I may have got a few things wrong :)
On 5/22/07, Richard S. Hall <[EMAIL PROTECTED]> wrote: > > Guillaume Nodet wrote: > > I guess I have been a bit misleaded by the fact that the > > config.propertiesfile > > is not included by default in the installers. After including the one > > provided, it seems > > to work because the following syntax is used: > > > > felix.auto.start.1= \ > > file:%INSTALL_PATH/bundle/org.apache.felix.shell-1.0-SNAPSHOT.jar \ > > file:%INSTALL_PATH/bundle/org.apache.felix.shell.tui-1.0-SNAPSHOT.jar \ > > file:%INSTALL_PATH/bundle/org.apache.felix.bundlerepository- > > 1.0-SNAPSHOT.jar > > > > However, I have no idea who substitutes the %INSTALL_PATH. > > Good news. > > So, is there some patch you can submit against the installers to get > this working "out of the box"? > > -> richard > > > > > > > On 5/22/07, Felix Meschberger <[EMAIL PROTECTED]> wrote: > >> > >> Hi, > >> > >> But the property AFAIK is a list of URLs not file system paths. You may > >> also > >> specify HTTP or whatever URLs you expect to be supported. > >> > >> Adding support for relative paths resolved locally, you temporarily > help > >> until you come up with a relative path containing blanks again and your > >> are > >> back to the start. So, all in all, I think, it is best to stick with > the > >> current setup, in which the property is a space separated list of > >> correctly > >> encoded URLs. > >> > >> Regards > >> Felix > >> > >> On 5/22/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote: > >> > > >> > Yeah, but I would assume that Felix is independent of the > installation > >> > folder > >> > and thus you don't have to specify the absolute path when loading > >> bundles. > >> > The problem is in the "C:\Program Files\felix-xxx", that's why I > >> suggested > >> > to > >> > resolve bundles uris from the home dir. > >> > > >> > On 5/22/07, Felix Meschberger <[EMAIL PROTECTED]> wrote: > >> > > > >> > > Hi, > >> > > > >> > > I also had this problem and it turns out, that the URLs are > actually > >> > wrong > >> > > because space is an unsafe character ([1]) and must always be > >> encoded. > >> > > Unfortunately, the java.io.File.toURL() method handles blanks in > >> path > >> > > names > >> > > incorrectly and does NOT encoded them. The workaround since Java > >> 1.4is > >> > to > >> > > use java.io.File.toURI().toURL() (or just File.toURI().toString() > >> when > >> > > preparing properties). > >> > > > >> > > So, IMHO Felix is quite correct assuming a space delimited list is > >> safe > >> > > and > >> > > ok. > >> > > > >> > > Regards > >> > > Felix > >> > > > >> > > [1] - http://www.faqs.org/rfcs/rfc1738.html, Section 2.2 URL > >> Character > >> > > Encoding Issues > >> > > > >> > > On 5/22/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote: > >> > > > > >> > > > I'm trying to understand how to configure / use the daemon / > >> > installer. > >> > > > > >> > > > After having changed the installers/pom.xml to reference the > >> released > >> > > > version > >> > > > of ApacheDS (1.0-RC2 instead of 1.0-RC2-SNAPSHOT) i was able to > >> build > >> > > > the felix installers and install them on Windows. > >> > > > > >> > > > One of the problem was the lack of a felix configuration file, > >> so I > >> > > copied > >> > > > the one > >> > > > i used and try to start the service. > >> > > > Unfortunately, on Windows, the service is run from > >> C:\windows\system32 > >> > > > folder (or something like that), so I had troubles configuring > >> bundles > >> > > > using > >> > > > the felix.auto.start.1 property. > >> > > > > >> > > > I've tried by prefixing the values with ${felix.home} that way > >> > > > felix.auto.start.1= \ > >> > > > file:${felix.home}/bundle/org.apache.felix.shell- > >> > > > 0.9.0-incubator-SNAPSHOT.jar \ > >> > > > file:${felix.home}/bundle/org.apache.felix.shell.tui- > >> > > > 0.9.0-incubator-SNAPSHOT.jar \ > >> > > > file:${felix.home}/bundle/org.apache.felix.bundlerepository- > >> > > > 0.9.0-incubator-SNAPSHOT.jar > >> > > > > >> > > > but unfortunately, I had the following output: > >> > > > > >> > > > ERROR: Auto-properties install. > >> (org.osgi.framework.BundleException: > >> > > > Unable > >> > > > to cache bundle: file:C:\Program) > >> > > > ERROR: Auto-properties install. > >> (org.osgi.framework.BundleException: > >> > > > Unable > >> > > > to cache bundle: Files\felix-0.9.0-incubator-SNAPSHOT > >> > > > /bundle/org.apache.felix.shell-0.9.0-incubator-SNAPSHOT.jar) > >> > > > ERROR: Auto-properties install. ( > >> org.osgi.framework.BundleException > >> : > >> > > > Unable > >> > > > to cache bundle: file:C:\Program) > >> > > > ERROR: Auto-properties install. > >> (org.osgi.framework.BundleException: > >> > > > Unable > >> > > > to cache bundle: Files\felix-0.9.0-incubator-SNAPSHOT > >> > > > /bundle/org.apache.felix.shell.tui-0.9.0-incubator-SNAPSHOT.jar) > >> > > > ERROR: Auto-properties install. > >> (org.osgi.framework.BundleException: > >> > > > Unable > >> > > > to cache bundle: file:C:\Program) > >> > > > ERROR: Auto-properties install. > >> (org.osgi.framework.BundleException: > >> > > > Unable > >> > > > to cache bundle: Files\felix- 0.9.0-incubator-SNAPSHOT > >> > > > /bundle/org.apache.felix.bundlerepository- > >> 0.9.0-incubator-SNAPSHOT.jar > >> > ) > >> > > > > >> > > > So it seems the space in "C:\Program Files\" is a problem. > >> > > > > >> > > > Did I miss something on the previous steps ? Is that a known > >> problem > >> ? > >> > > > > >> > > > -- > >> > > > Cheers, > >> > > > Guillaume Nodet > >> > > > ------------------------ > >> > > > Principal Engineer, IONA > >> > > > Blog: http://gnodet.blogspot.com/ > >> > > > > >> > > > >> > > >> > > >> > > >> > -- > >> > Cheers, > >> > Guillaume Nodet > >> > ------------------------ > >> > Principal Engineer, IONA > >> > Blog: http://gnodet.blogspot.com/ > >> > > >> > > > > > > > -- Cheers, Guillaume Nodet ------------------------ Principal Engineer, IONA Blog: http://gnodet.blogspot.com/
-- Cheers, Stuart
