Marcel Offermans wrote:
Hi Stefano,
On Sep 20, 2007, at 19:45 , Stefano Lenzi wrote:
I would like to discuss two point:
- Should Felix use only a Code Style or should rely on other project
code style when the component created by Felix is used into other
projects? For instance: should the Maven plugin maintained by Felix
use the Maven code style or Felix code style?
I think that everything we develop in our repository should use the
code style we defined. Using code styles of other projects seems more
confusing to me.
+1
Another issue, but that's not the discussion of this thread, is if we
should maintain for example Maven plugins in the Felix project at all.
We had the same discussion for the commons wrappers already.
Eventually, I would like to donate those pieces of code to the
respective projects.
But, back to this discussion...
For me, I am not so sure about this one. I am not sure if makes sense,
for example, for us to donate the bundle plugin to Maven, since the area
of expertise around OSGi is in Felix, so if people have questions about
stuff they will likely want answers from us, not from Maven guys.
However, if Maven started to become much more OSGi-centered, then my
position on this could change.
From my point of view, it makes sense that we (i.e., Felix community)
develop tools that make it easier for people to use Felix (e.g.,
bundleplugin). The fact that bundleplugin uses Maven is just an
implementation issue. For example, mangen does a similar job as
bundleplugin, but it is not based on maven, so what would we do with
that? Of course, we wouldn't do anything with it. The point is that we
are making tools to help people use Felix and these tools should be part
of the Felix project, no matter what technology they are implemented on
top of.
- I know that Clement has create a Checksytle and a Eclipse
formatter complaint to the Felix coding style. I think that we
reserve a location in our repository for providing such file to
developer and also try to keep it updated. It's worth to notice that
the Checkstyle configuration file could be both by Maven and IDE.
The most important thing is to maintain a document that describes our
code style. Everything else is optional in my opinion, since probably
we all have different preferences when it comes to IDE's. That said, I
do appreciate the fact that Clement has provided these files. I don't
care if they're maintained in svn or the wiki however.
Agreed.
-> richard
Greetings, Marcel
