[
https://issues.apache.org/jira/browse/FELIX-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548031
]
Lucas Galfaso commented on FELIX-428:
-------------------------------------
Please let me know if I got right the specific reasons for the patch and the
consequences.
.) Provide a log mechanism when Felix is used in another framework just to log
the startup of the framework.
.) Use of syso is not good enough, and redirecting syso to some other logger
is not possible/recommended.
.) Setting the log level of just this logger to 0 (and then use the standard
Log service) is not an option.
.) The user will have to be aware that if the Log service is installed they
will have to implement a second log mechanism to capture logs, and be sure that
they do not get confused by this fact.
I think that the cons (this is to put the burden to the user to implement two
log mechanisms to capture the logs and the fact that this solution would be
very Felix specific) is bigger that the pros. Anyhow I do see some value to the
patch.
If this patch is included, then I see a few things that I would not do, these
involve the fact that this class is suppose to mock the standard Log service,
so I would not add the methods "setLogLevel", "getLogLevel" (these are not in
the Logger that it was intended to replace) and I would not remove the stack
trace in the case or an "error" log. Again, this is just my opinion.
> Support Application supplied Logger instance for the framework
> --------------------------------------------------------------
>
> Key: FELIX-428
> URL: https://issues.apache.org/jira/browse/FELIX-428
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Felix Meschberger
> Attachments: FELIX-428.patch
>
>
> In certain environments where the Felix framework is embeded, the environment
> may provide a logging facility which should be used by the framework as long
> as no OSGi LogService is available.
> For example, in Sling we have a web application based launcher, which embeds
> the Felix framework in a web application. In this case, it would be usefull
> to have the log messages being directed to the ServletContext.log methods
> until the LogService is set up.
> Will attach a patch to implement this feature.
> WDYT ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
