[
https://issues.apache.org/jira/browse/FELIX-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604824#action_12604824
]
fmeschbe edited comment on FELIX-584 at 6/13/08 5:35 AM:
------------------------------------------------------------------
Committed a first step towards the enhancement of the Configuration Admin GUI.
The page now displays two selection list (see attachement), one for regular
configurations and one for factory configurations.
When selecting a regular configuration (also a factory configuration instance
is a regular configuration) it is displayed for editing.
When selecting a factory configuration, a new configuration object is created
and displayed for editing.
Implemented in Rev. 667498 and deployed SNAPSHOT build 1.0.1-20080613.123406-2
was (Author: fmeschbe):
Committed a first step towards the enhancement of the Configuration Admin
GUI. The page now displays two selection list (see attachement), one for
regular configurations and one for factory configurations.
When selecting a regular configuration (also a factory configuration instance
is a regular configuration) it is displayed for editing.
When selecting a factory configuration, a new configuration object is created
and displayed for editing.
> org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.applyConfiguration():
> "create" action is not handled properly
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-584
> URL: https://issues.apache.org/jira/browse/FELIX-584
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Reporter: Dieter Wimberger
> Assignee: Felix Meschberger
> Attachments: AjaxConfigManagerAction.java.diff, FELIX-584-1.png
>
>
> The current revision of the code (662145) creates the configuration, and
> returns true.
> else if ( request.getParameter( "create" ) != null )
> {
> // pid is a factory PID and we have to create a new configuration
> // we should actually also display that one !
> Configuration config = ca.createFactoryConfiguration( pid, null );
> // request.setAttribute(ATTR_REDIRECT_PARAMETERS, "pid=" +
> // config.getPid());
> return true;
> }
> The problem with this approach is the fact that in many cases the
> Configuration instance will not be persisted or available until the update()
> method is used to set new properties.
> Based on the fact that the "create" action may be called already with a
> complete set of properties edited in the form, I would suggest to only
> differentiate between factory "create" and "save" in the way the
> Configuration instance is created. i.e.:
> if ( request.getParameter( "create" ) != null )
> {
> // pid is a factory PID and we have to create a new configuration
> config = ca.createFactoryConfiguration( pid, null );
> } else {
> // pid is managed service, get configuration
> config = ca.getConfiguration( pid, null );
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
