[ 
https://issues.apache.org/jira/browse/FELIX-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610946#action_12610946
 ] 

Stuart McCulloch commented on FELIX-620:
----------------------------------------

No - it does read the instructions from osgi.bundle2 (you can confirm this by 
adding a unique entry like "TEST:ME") - the issue here is actually that the 
manifest goal is overwriting the included property with a default export based 
on the contents of the jar, because it checks for the existence of the export 
instruction in the original POM instructions rather than the merged 
instructions.

BTW, there is also a typo in osgi.bundle2 where it uses "_exportcontents", 
rather than  "-exportcontents".

Instructions inside included files are processed by Bnd, so it expects the 
notation described on Peter's website (http://aqute.biz/Code/Bnd#directives) 
i.e. "-exportcontents".  However, because XML doesn't allow tags that start 
with '-' we can't have <-exportcontents> in the POM, so instead we accept 
<_exportcontents> and transform this internally to "-exportcontents" before 
passing it onto Bnd. But this is only for the POM to get around the XML tag 
restriction.



> manifest goal of maven-bundle-plugin ignores _include instruction
> -----------------------------------------------------------------
>
>                 Key: FELIX-620
>                 URL: https://issues.apache.org/jira/browse/FELIX-620
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-1.4.1
>         Environment: Maven version: 2.0.7
> Java version: 1.5.0_13-rev
> OS name: "sunos" version: "5.11" arch: "x86"
>            Reporter: Sahoo
>             Fix For: maven-bundle-plugin-1.4.2
>
>         Attachments: Felix-620.zip
>
>
> It appears to me that if I just invoke *manifest* goal of 
> maven-bundle-plugin, it ignores *_include* instruction, where as if I use 
> *bundle* goal, it is used by the plugin. There are various ways to test it. 
> The easiest seems to be using a non-existent file name. Attached are two sets 
> of pom files, pom.xml uses bundle goal, where as pom.xml.notworking uses 
> manifest goal. While using the first one, bnd complains about missing 
> osgi.bundle3 file, where as it does not report any such error while using the 
> first one. That makes me think that the manifest Mojo is not sending the file 
> name to bnd. 
> I am attaching a very simple test case along with a README describing the 
> issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to