[ 
https://issues.apache.org/jira/browse/FELIX-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648691#action_12648691
 ] 

Richard S. Hall commented on FELIX-820:
---------------------------------------

I would be more inclined to follow your second, less invasive approach. I think 
we are going to do some major refactoring before long in these abstractions, so 
no reason to do anything major now.

I don't think there is any reason to have a "setIsFragment()" since this is not 
something that is set-able, it either is or it isn't. I would propose something 
like the following:

* Move isFragment() to framework.util.Util...it can probably be made static now.
* In _startBundle(), use the isFragment() method to check for a fragment and 
throw an appropriate exception.


> Throw an exception when starting a fragment bundle
> --------------------------------------------------
>
>                 Key: FELIX-820
>                 URL: https://issues.apache.org/jira/browse/FELIX-820
>             Project: Felix
>          Issue Type: Sub-task
>          Components: Framework, Specification compliance
>    Affects Versions: felix-1.4.0
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>             Fix For: felix-1.4.1
>
>
> The spec says attempts to start a fragment should result in an exception. 
> Make it so.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to