JarContent logs and then swallows exceptions when reading from JAR file, should 
probably throw an exception
-----------------------------------------------------------------------------------------------------------

                 Key: FELIX-883
                 URL: https://issues.apache.org/jira/browse/FELIX-883
             Project: Felix
          Issue Type: Improvement
          Components: Framework
    Affects Versions: felix-1.4.1
            Reporter: Richard S. Hall
            Priority: Minor
             Fix For: felix-1.6.0


As a specific example, if there is an error opening the JAR file, JarContent 
currently logs an exception and then returns null for methods like 
getEntryAsBytes(). Such an exception should likely never happen, however in 
some highly dynamic situations it does; for example, if there bundles are being 
updated and refreshed at short intervals. In such situations, it is possible 
there will be an outstanding class load request for a JAR file that has been 
deleted, which can cause an exception. Since this is the likely cause, it might 
be better to throw an runtime exception at this point saying something to the 
effect of "the bundle was probably refreshed", rather than just logging it and 
continuing. There are multiple places where we should change this in 
JarContent. I don't think it impacts other IContent implementations, since they 
are typically used for install-by-reference, which never get deleted. Stil, we 
should investigate them too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to