[
https://issues.apache.org/jira/browse/FELIX-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668134#action_12668134
]
Richard S. Hall commented on FELIX-902:
---------------------------------------
Still, shouldn't the second issue be resolved by the first issue? Now, if for
some reason there is an empty file created, it will be interpreted as being the
INSTALLED state. Said another way, there is really only one bug here, which is
under some circumstances an empty state file might be created, so we need to
handle that when we read the state file. Would you agree?
> Empty bundle.state file produces NPE
> ------------------------------------
>
> Key: FELIX-902
> URL: https://issues.apache.org/jira/browse/FELIX-902
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.0.4
> Reporter: Pavel Tiunov
> Assignee: Richard S. Hall
> Priority: Critical
>
> If I have empty bundle.state file in Felix cache then exception is thrown
> while bundle start:
> java.lang.NullPointerException
> at
> org.apache.felix.framework.cache.BundleArchive.getPersistentState(BundleArchive.java:315)
> at org.apache.felix.framework.Felix.start(Felix.java:776)
> But if i delete bundle.state then no exception is thrown and
> org.apache.felix.framework.cache.BundleArchive#getPersistentState returns
> 'Installed' state.
> The exception is thrown because string comparsions in
> org.apache.felix.framework.cache.BundleArchive#getPersistentState do not
> respect java.io.BufferedReader#readLine's null return value if file is empty.
> Also there is a bug in
> org.apache.felix.framework.cache.BundleArchive#setPersistentState that can
> produce not persistent state of cache by creation of empty bundle.state file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
