2009/2/9 Richard S. Hall <[email protected]> > Does anyone know/remember why we may have disabled the default Maven > release profile? It seems this makes it so we don't publish our source or > JavaDoc. >
the subversion logs show this has always been there since Carsten added the release profile to the main Felix pom: svn diff -r604235:r604236 pom/pom.xml perhaps it was disabled because we define our own release profile? Carsten may have wanted to avoid potential conflicts between our profile and the default Maven profile - if that's the case then we could always just add the source and javadoc plugin entries to our release profile... I certainly have no idea. > hopefully Carsten can explain the reasoning behind it :) > -> richard > > Juhos, Pavol wrote: > >> Karl, Richard, >> >> I've looked at Felix POM files and found the reason why the source-jars >> and javadoc-jars are not included in your releases. As mentioned before >> these artifacts are created by _default_ Maven release lifecycle, however >> the default Maven release profile is disabled in your master POM file >> (trunk/pom/pom.xml). It there some specific reason for this? >> I'm attaching a trivial patch that basically removes the following line >> from the POM: >> >> <useReleaseProfile>false</useReleaseProfile> >> >> If you are not sure what the default profile is doing here is the relevant >> excerpt from the Maven super-pom (implicit root of all POMs): >> >> <profile> >> <id>release-profile</id> >> >> <activation> >> <property> >> <name>performRelease</name> >> <value>true</value> >> </property> >> </activation> >> >> <build> >> <plugins> >> <plugin> >> <inherited>true</inherited> >> <groupId>org.apache.maven.plugins</groupId> >> <artifactId>maven-source-plugin</artifactId> >> <executions> >> <execution> >> <id>attach-sources</id> >> <goals> >> <goal>jar</goal> >> </goals> >> </execution> >> </executions> >> </plugin> >> <plugin> >> <inherited>true</inherited> >> <groupId>org.apache.maven.plugins</groupId> >> <artifactId>maven-javadoc-plugin</artifactId> >> <executions> >> <execution> >> <id>attach-javadocs</id> >> <goals> >> <goal>jar</goal> >> </goals> >> </execution> >> </executions> >> </plugin> >> <plugin> >> <inherited>true</inherited> >> <groupId>org.apache.maven.plugins</groupId> >> <artifactId>maven-deploy-plugin</artifactId> >> <configuration> >> <updateReleaseInfo>true</updateReleaseInfo> >> </configuration> >> </plugin> >> </plugins> >> </build> >> </profile> >> See >> http://svn.apache.org/repos/asf/maven/components/tags/maven-2.0.9/maven-project/src/main/resources/org/apache/maven/project/pom-4.0.0.xmlfor >> reference. >> >> Another potential solution might be to use the default release profile >> only for selected modules. I.e. "override" the maven-release-plugin >> configuration by including the following piece into the modules' POMs: >> >> <plugin> >> <groupId>org.apache.maven.plugins</groupId> >> <artifactId>maven-release-plugin</artifactId> >> <configuration> >> <useReleaseProfile>true</useReleaseProfile> >> </configuration> >> </plugin> >> >> What are your thoughts on this? >> Kind regards, >> >> >> Pavol Juhos >> Hewlett-Packard Company >> [email protected] >> >> P.S.: If this level of technical detail is not appropriate for this >> mailing list please let me know and we can take this discussion "offline" or >> to the devel list. >> >> >> -----Original Message----- >> From: Karl Pauls [mailto:[email protected]] Sent: Sunday, February 08, >> 2009 10:44 PM >> To: [email protected] >> Subject: Re: Deploying Felix source jars to Maven central repository >> >> I do upload what is produced by maven. If we are missing some >> configuration that would make that better please do provide a patch! >> >> regards, >> >> Karl >> >> On Sun, Feb 8, 2009 at 10:30 PM, Juhos, Pavol <[email protected]> wrote: >> >> >>> Hello Richard, >>> >>> Yes you are right, the Maven release lifecycle produces the source-jars >>> by default. It is just a matter of uploading these source-jar artifacts to >>> the repository. Also no less important than source-jars are the javadoc jars >>> (also produced by maven-release-plugin by default) -- especially in the >>> current situation when Felix JavaDoc documentation is not available online >>> (at least not to my knowledge). >>> >>> In case you would need any help with the Maven configuration just let me >>> know. I would be happy to assist. >>> >>> Best regards, >>> >>> >>> Pavol Juhos >>> Hewlett-Packard Company >>> [email protected] >>> >>> -----Original Message----- >>> From: Richard S. Hall [mailto:[email protected]] >>> Sent: Thursday, February 05, 2009 7:47 PM >>> To: [email protected] >>> Subject: Re: Deploying Felix source jars to Maven central repository >>> >>> We are using Maven to create the releases and it generates a source >>> release archive too. Is it just a matter of uploading its source >>> release? If so, it should be do-able I would guess. >>> >>> -> richard >>> >>> Juhos, Pavol wrote: >>> >>> >>>> Hello Felix team, >>>> >>>> It would be very helpful if you could also deploy JAR files containing >>>> the source code to the Maven repositories. It really helps to have the >>>> source code around when developing in IDEs like Eclipse. To give you a >>>> better picture, M2eclipse (= Eclipse Maven Integration) allows you to >>>> download sources for any of your Maven dependencies in one click if they >>>> are >>>> properly deployed in the repository. Generally I think deploying source >>>> jars >>>> is becoming a good practice for open-source projects using Maven. Thank >>>> you. >>>> >>>> Best regards, >>>> >>>> >>>> Pavol Juhos >>>> Enterprise Software >>>> Consultant, System Integration >>>> Hewlett-Packard Company >>>> >>>> [email protected] >>>> www.hp.com/go/exstream >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >>>> >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>> >>> >> >> >> >> ------------------------------------------------------------------------ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > -- Cheers, Stuart
