> +1 > > Some points: > The Copyright year of the bundle repository is 2008. Should be 2009
I agree. Good catch. Just fix it in trunk :-) > Two file have no header in the framework. However, those files doesn't > contain any IP... > [ERROR] Missing licence in > release-org.apache.felix.framework-1.6.0/org.apache.felix.framework-1.6.0/src/main/resources/META-INF/services/org.osgi.framework.launch.FrameworkFactory > [ERROR] Missing licence in > release-org.apache.felix.framework-1.6.0/org.apache.felix.framework-1.6.0/src/main/resources/org/apache/felix/framework/Felix.properties As you say, they don't contain anything worthwhile a header IMO. The header would be much longer then the content so I would prefer not adding it. We probably should add them to the rat excludes. regards, Karl > Regards, > > Clement > > On 03.04.2009, at 08:39, Rob Walker wrote: > >> +1 >> >>>> I would like to call a vote on the following subproject releases, >>>> >>>> shell 1.2.0 >>>> shell.tui 1.2.0 >>>> bundlerepository 1.4.0 >>>> framework 1.6.0 >>>> main 1.6.0 >>>> >>>> The source and binary release archives, signature files, SHA and MD5 >>>> message digests for each are available as zip and tar.gz here: >>>> >>>> http://people.apache.org/~pauls/1.6.0 >>>> >>>> Additionally, a binary release is included (called felix-1.6.0). >>>> >>>> Please vote to approve these release archives: >>>> >>>> [ ] +1 Approve the releases >>>> [ ] -1 Veto the releases (please provide specific comments) >>>> >>>> >>> >>> >>> >>> >> >> -- >> >> >> Ascert - Taking systems to the Edge >> [email protected] >> +44 (0)20 7488 3470 >> www.ascert.com >> > > -- Karl Pauls [email protected]
