[ 
https://issues.apache.org/jira/browse/FELIX-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702859#action_12702859
 ] 

Richard S. Hall commented on FELIX-1000:
----------------------------------------

Yes, this patch looks better. However, I do have a question, what semantic are 
you trying to achieve here? It is purely to eliminate the exception you receive 
when updating an OBR installed bundle? If so, then I guess the current patch 
achieves this. I guess I thought you actually wanted OBR to attempt to update 
the bundle.

For example, if you update a given OBR-installed bundle, you could actually 
have OBR check to see if there is a newer version of the bundle in the repo and 
if so return an input stream to it. If there is no new version, then OBR could 
just return the same input stream. The current approach always updates to the 
same version.

What do you and others think?

> Updating an bundle which was installed via OBR fails
> ----------------------------------------------------
>
>                 Key: FELIX-1000
>                 URL: https://issues.apache.org/jira/browse/FELIX-1000
>             Project: Felix
>          Issue Type: Bug
>          Components: Bundle Repository (OBR)
>            Reporter: Kristian Koehler
>         Attachments: FELIX-1000-21_04_2009.patch.txt, 
> FELIX-1000-23_04_2009.patch.txt
>
>
> Updating an bundle which was installed via the obr functionality results in 
> an exception (update was triggered via the shell):
> --- 8< ---
> java.net.MalformedURLException: Unknown protocol: obr
>       at java.net.URL.<init>(URL.java:601)
>       at java.net.URL.<init>(URL.java:464)
>       at java.net.URL.<init>(URL.java:413)
>       at 
> org.apache.felix.framework.cache.JarRevision.initialize(JarRevision.java:149)
>       at 
> org.apache.felix.framework.cache.JarRevision.<init>(JarRevision.java:78)
>       at 
> org.apache.felix.framework.cache.JarRevision.<init>(JarRevision.java:56)
>       at 
> org.apache.felix.framework.cache.BundleArchive.createRevisionFromLocation(BundleArchive.java:986)
>       at 
> org.apache.felix.framework.cache.BundleArchive.revise(BundleArchive.java:614)
>       at org.apache.felix.framework.BundleImpl.revise(BundleImpl.java:916)
>       at org.apache.felix.framework.Felix.updateBundle(Felix.java:1592)
>       at org.apache.felix.framework.BundleImpl.update(BundleImpl.java:792)
>       at org.apache.felix.framework.BundleImpl.update(BundleImpl.java:779)
>       at 
> org.apache.felix.shell.impl.UpdateCommandImpl.execute(UpdateCommandImpl.java:96)
>       at 
> org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:276)
>       at 
> org.apache.felix.shell.tui.Activator$ShellTuiRunnable.run(Activator.java:167)
>       at java.lang.Thread.run(Thread.java:619)
> --- 8< ---

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to