On Mon, Jun 15, 2009 at 13:14, Filippo Diotalevi<[email protected]> wrote: > On Mon, Jun 15, 2009 at 10:45 AM, Guillaume Nodet<[email protected]> wrote: >> I'd like to start discussing how we can merge karaf deployer and felix >> fileinstall. >> Note that karaf deployer is originally based on the same code base but >> has since evolved. > > FileInstall has evolved a lot in the last 3 months [1], so it may be > not a simple merge. It's now even a part of Glassfish! (besides > playing also an important role in my osgi applications). > > In terms of functionality, I am certainly interested in having the > possibility to handle war bundles, when the spec is ready; and also >> * ability to handle exploded bundles > sounds nice. > > On the other side, I use FileInstall a lot also for my experiments and > proof-of-concept, and I appreciate the fact that I can use it with > just a minimal setup (core+shell+fileinstall). I believe that was > Peter Kriens' original idea, and we have always tried to keep that in > mind when we added the functionalities we needed in the last few > months. > >> Here are a list of the main features we've added to the karaf deployer >> over time: >> * use the preference service (if available) to store the status of >> the deployer >> thus the last update time for each tracked object is stored and >> at restart the deployer >> is able to detect changed files >> * ability to handle exploded bundles >> * ability to transform artifacts on the fly (wars, spring config >> files, blueprint config files, etc...) through OSGi services >> this issue has been raised in FELIX-922 > > What are the additional bundles required for such new functionalities? > Is it possible to keep them optional? >
For exploded bundles and custom deployers, there's no additional dependencies. Custom deployers are handled by using a ServiceTracker tracking for a known interface, that's all. > > Anyway, I'm always in favour of enhancing FI, while maintaing its > simplicity and flexibility. It serves me very well in my projects and > very soon I'll need also the "deploy war" functionality, so I'll be > happy to help. > > If we want to start with the FI codebase, one thing we may need is to > complete the suite of unit tests, so we are (well, relatively) sure > not to introduce regressions. I started it a while ago, but stopped > since writing easymock1.2 tests was too painful and tests too fragile. > Now that the main pom contains also mockito1.7 and junit4.5, I can > complete it. > > > [1] I count 14 issues closed since Feb at > http://issues.apache.org/jira/secure/IssueNavigator.jspa?sorter/field=updated&sorter/order=DESC > -- > Filippo Diotalevi > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
