There appears to be a bug. startAllBundles() should not be called the way it is done right now. I say this because, that's the very reason why I introduced startupFailures. So, in principle, we should only start failed bundles and newly installed bundles.

Thanks,
Sahoo

Guillaume Nodet wrote:
I'm trying to understand the rational behind some code in fileinstall.
There is a map variable named startupFailures which is supposed to contain
bundles that have not been successfully started.
But bundles are currently only started when calling the startAllBundles,
which does as it says and start all the bundles.
So there's no need to try starting the failed bundles before imho.

In addition, I think it would be a good enhancement to only start failed
bundles and newly installed bundles (maybe using some flag),
as this would allow the user to manually stop a bundle without having
fileinstall to start it again automatically.

Thoughts ?

Reply via email to