I've committed those 3 patches, but I'm happy to continue the discussion.
For 1481, I'd be perfectly happy to add an escaping mechanism and keep
throwing an exception.
So if you want to use '$', '{' or '}' inside one value, you'd have to use
'\\$', '\\{' or '\\}' to escape those.
On Fri, Aug 14, 2009 at 10:53, Filippo Diotalevi <
filippo.diotal...@gmail.com> wrote:
> On Thu, Aug 13, 2009 at 11:00 AM, Guillaume Nodet<gno...@gmail.com> wrote:
> > I've raised a few jira issues on fileinstall that can be found at
> >
> >
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310100&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12312204
> >
> > I plan to commit the attached patches for FELIX-1475, FELIX-1481,
> FELIX-1476
> > asap, so please review those and provide feedback is needed.
>
> Hi,
> I've reviews 1475, 1476 and they look ok.
>
> 1481 (throw exception when stop delimiter isn't found): that was
> actually a good feature for me, because I could easily spot wrong
> configurations. However, if you need to have { } characters in your
> properties, I don't think there're other choices other than discarding
> the esception.
>
>
> --
> Filippo Diotalevi
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
