[ 
https://issues.apache.org/jira/browse/FELIX-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747317#action_12747317
 ] 

David Savage commented on FELIX-1521:
-------------------------------------

Ok the latest attachment looks good, though it is a little out of place with 
the actual implementation of the parser as lines must be terminated with a ";" 
(FELIX-1487)

So whilst the following passes in the grammar

foo = {
  echo $it
  echo $it again
}

In the current gogo parser this would need to be

foo = {
  echo $it;
  echo $it again;
};

I prefer the syntax in the grammar but this requires that the parser take LT 
into account when parsing.

Also there is a problem with the use of ValuePart to represent commands as 
commands have restrictions based on the java language spec (they will be 
translated into method calls) so cannot contain characters such as '-'


> [gogo] ANTLR grammar for gogo
> -----------------------------
>
>                 Key: FELIX-1521
>                 URL: https://issues.apache.org/jira/browse/FELIX-1521
>             Project: Felix
>          Issue Type: New Feature
>          Components: Gogo
>            Reporter: Guillaume Nodet
>         Attachments: gogo.g, gogo.g, gogo.g
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to