On Wed, Sep 9, 2009 at 1:53 AM, Don Brown<[email protected]> wrote: > As you may have noticed from the issues, I'm getting several > concurrency failures in the rewritten URLHandlers code after upgrading > from 1.2.1. These bugs are keeping my plugin builds red about 95% of > the time, which is basically a showstopper. I see Karl has a fix for > the deadlock [1],
I just committed a fix. > and I just filed the race condition [2], As you figured out yourself, its not a race condition but an oversight from the refactoring. I committed a fix as well. > so assuming they get fixed on trunk soon, how soon could I get a Felix 2.0.1? Well, I'm expecting to see some more bugs when people start to move to 2.0.0 so I would like to wait a little in order to collect a couple of more bugs for 2.0.1. How soon do you need it? > Alternatively, I could rollback to my fork of 1.2.1, but I'd hate to > do that due to some bugs in class resolution that were fixed in later > releases. I guess I could also fork 1.8.1 or 2.0.0, but I'd really > rather not. Well, one thing that would help is if you could test the fixes soon and let us know whether that resolves your problem. > Also, I'm surprised no one else has seen this deadlock before as it > seems to have been in the code for a while. Am I the only one that > has heaps of integration tests bringing Felix up and down? We do have quite some (internally) plus I know that others do too. The thing is that you are not just bringing felix up and down but you also are creating bundle:// urls from strings on the outside of the framework (or rather, spring is doing that for you :-) while your framework is being shutdown. Additionally, you have more then one framework inside the JVM. Together (bundle:// url from string on the outside plus several frameworks going up and down) you have what I would call the second most complicated use case I have for the URLHandlers (the worst would be if this is happening inside websphere :-). So not too many people test for this. Which reminds me, is there an easy way I can run your tests with trunk myself? That way I could make sure I do this next time before I do a release. regards, Karl > Don > > [1] https://issues.apache.org/jira/browse/FELIX-1565 > [2] https://issues.apache.org/jira/browse/FELIX-1573 -- Karl Pauls [email protected]
