On 9/10/09 13:37, Guillaume Nodet wrote:
Well, i'd rather do it clean so that those issues don't pop up next time ...
And the missing asf header was worrisome to me.
Yeah, I didn't catch that one.
If you want, I can look at the next artifacts before calling the vote
this time...
-> richard
On Thu, Sep 10, 2009 at 19:11, Richard S. Hall<[email protected]> wrote:
I don't think canceling the vote was necessary for these changes, which is
why I gave it a "+1"...
-> richard
On 9/10/09 12:37, Guillaume Nodet wrote:
Sounds good. I've also fixed a missing ASF header I found on one file.
Btw, the commands module actually include the ReifiedType class from
the blueprint api (hence copyrighted to OSGi).
I'll recut a release with those changes, hopefully the last one. The
first release of a project is always a pain ...
On Thu, Sep 10, 2009 at 16:19, Richard S. Hall<[email protected]>
wrote:
+1
Looks much better, however:
* The commands and console NOTICE files says they include OSGi
software, but they don't appear to do so.
* All NOTICE files say "Apache Felix Gogo", but each artifact should
have its own name, e.g., "Apache Felix Gogo Commands".
-> richard
On 9/10/09 6:08, Guillaume Nodet wrote:
I've uploaded a new release of gogo with fixed NOTICE in all bundles.
Staging repository:
https://repository.apache.org/content/repositories/felix-staging-055/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 55 /tmp/felix-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)
This vote will be open for 72 hours.
