[
https://issues.apache.org/jira/browse/FELIX-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756517#action_12756517
]
Derek Baum commented on FELIX-1406:
-----------------------------------
This template looks good, but still has two differences that I'm not sure about:
1. no space after the : in a Java5 for loop:
- for (Method m : methods)
+ for (Method m: methods)
2. javadoc comment is changed into non-javadoc comment and blank lines are
inserted between parameters:
(gogo/Reflective.java):
- /**
+ /*
* Complex routein to convert the arguments given from the command line to
* the arguments of the method call. First, an attempt is made to convert
* each argument. If this fails, a check is made to see if varargs can be
* applied. This happens when the last method argument is an array.
- *
+ *
* @param session
+ *
* @param target
+ *
* @param types
+ *
* @param out
+ *
* @param in
+ *
* @return
+ *
* @throws Exception
*/
@SuppressWarnings("unchecked")
- private int coerce(CommandSession session, Object target, Class<?>
types[], Object out[], List<Object> in) throws Exception
+ private int coerce(CommandSession session, Object target, Class<?> types[],
+ Object out[], List<Object> in) throws Exception
{
> eclipse code format template does not match existing code
> ---------------------------------------------------------
>
> Key: FELIX-1406
> URL: https://issues.apache.org/jira/browse/FELIX-1406
> Project: Felix
> Issue Type: Bug
> Components: Documentation
> Reporter: Derek Baum
> Priority: Minor
> Attachments: ApacheFelixEclipseTemplate.xml
>
>
> The eclipse code format template
> http://felix.apache.org/site/coding-standards.data/ApacheFelixCodingStandards.xml
> generates slightly different white space and blank line formatting than
> existing felix code.
> Specifically:
> 1. spaces are inserted after the opening paren and before the closing paren
> in declarations and method calls:
> int method1( String arg1 )
> {
> if ( expr )
> {
> method1( arg1 );
> }
> }
> The felix coding standards document
> http://felix.apache.org/site/coding-standards.html does not specifically
> specify these spaces,
> but all the examples show code formatted without them.
> 2. two blank lines are inserted after package statement and between method
> declarations
> This actually agrees with the eclipse template, but the code I was
> reformatting (gogo) only had one blank line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
