[ 
https://issues.apache.org/jira/browse/FELIX-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759049#action_12759049
 ] 

Felix Meschberger commented on FELIX-1636:
------------------------------------------

Committed a slightly modified (and fixed as per the above comment) version of 
the patch in Rev. 818395:

only render header/footer if the request is plain HTML plugin request indicated 
by the absence of any extension or the extension being ".html". Any request 
containing a non-".html" extension is directly handled by the renderContent 
method without rendering any header and footer.

> Html footer and header are always added to the response for a servlet plugin
> ----------------------------------------------------------------------------
>
>                 Key: FELIX-1636
>                 URL: https://issues.apache.org/jira/browse/FELIX-1636
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-2.0.0
>            Reporter: Carsten Ziegeler
>            Assignee: Felix Meschberger
>             Fix For: webconsole-2.0.0
>
>         Attachments: AbstractWebConsolePlugin.java.patch
>
>
> If a plugin is registered as a plain servlet, the WebConsolePluginAdapter 
> wraps this servlet and handle GET requests
> Regardless of the requested uri, the html header and footer is always added 
> to the response which causes messed uprequests if the servlet wants to 
> generate dynamic json (or other stuff).
> I guess the easiest way is to check the extension in the 
> AbstractWebConsolePlugin#doGet()
> After the check for spoolResource a check of the extension could be made - if 
> no extension or htm or html, put the footer or header around. For any other 
> extension just invoke render.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to