[ 
https://issues.apache.org/jira/browse/FELIX-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805835#action_12805835
 ] 

Felix Meschberger commented on FELIX-2012:
------------------------------------------

Yes, in the case of a the root ...

still -- theoretically -- the URL may be invalid (as you check in the method 
with trying to get the InputStream).

In this case you should also not return the URL (what would the check be useful 
for anyway ?)

... and if the check is successfull, you don't close the InputStream, which 
IMHO is very bad.

> NullPointerException when some links clicked if karaf.framework=equinox
> -----------------------------------------------------------------------
>
>                 Key: FELIX-2012
>                 URL: https://issues.apache.org/jira/browse/FELIX-2012
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: karaf-1.2.0
>         Environment: Windows XP, Ubuntu 9.10
>            Reporter: David Porter
>            Assignee: Freeman Fang
>             Fix For: karaf-1.4.0
>
>
> To reproduce:
> In the /etc/config.properties file, set karaf.framework=equinox
> Start Karaf.
> Install the webconsole feature.
> In your web browser, go to http://localhost:8181/system/console
> Log in as admin/admin
> Click the Admin, Features, or Gogo links in the nav bar at the top.
> Result:
> java.lang.NullPointerException
> at 
> org.apache.felix.webconsole.AbstractWebConsolePlugin.spoolResource(AbstractWebConsolePlugin.java:355)
> at 
> org.apache.felix.webconsole.AbstractWebConsolePlugin.doGet(AbstractWebConsolePlugin.java:103)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:693)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
> at 
> org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:314)
> at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:502)
> at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:363)
> at 
> org.ops4j.pax.web.service.internal.HttpServiceServletHandler.handle(HttpServiceServletHandler.java:64)
> at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
> at 
> org.ops4j.pax.web.service.internal.HttpServiceContext.handle(HttpServiceContext.java:111)
> at 
> org.ops4j.pax.web.service.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:64)
> at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> at org.mortbay.jetty.Server.handle(Server.java:324)
> at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:534)
> at 
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:864)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:533)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:207)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:403)
> at 
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
> at 
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:522)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to