[
https://issues.apache.org/jira/browse/FELIX-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentin Valchev updated FELIX-1988:
------------------------------------
Attachment: abstr-simple-web-console.patch
The attached patch includes the following changes:
- moves implementation of getParameter() and sendRedirect() methods from
AbstractWebConsolePlugin to WebConsoleUtil. The methods in
AbstractWebConsolePlugin remains for compatibility, but delegates to the one in
WebConsoleUtil.
- adds complete javadoc for AbstractWebConsolePlugin , WebConsoleUtil and
WebConsoleConstants
- adds new utility class SimpleWebConsolePlugin
I would like to mention that we talked with Felix to integrate
SimpleWebConsolePlugin into AbstractWebConsolePlugin but after I did it, I
found few problems, so it was my decision to leave it alone. The problems were:
- had to add default constructor to AbstractWebConsolePlugin for compatibility,
and another one with label, title and CSS as parameters. This would potentially
allow the developers to create instances with null label and title, which will
lead to error. Although it will not be hard to detect where the problem is it's
a good API design to prevent the developer from making easier to detect errors.
- the default implementation of getResource() made the test cases to fail. I
fixed them, but still, its better to preserve the original behavior (for
compatibility)
- register/unregister/getService - these methods are actually not directly
related to web console functionality, but are utilities, that eases the
developers. However, a developer can decide to implement a different scheme (as
example in ProSyst plugins, I use to register the plugin, only if the required
services are available, and unregister it when they disappear, so no service
tracking is required). So far, since the functionality provided is optional, I
decided that it's better to leave the decision on the developer to use either
the AbstractWebConsolePlugin or the easier SimpleWebConsolePlugin.
As for the SimpleWebConsolePlugin the benefits from using it are:
- developer write less code, and focuses right to the problem - the servlet
itself
- the build in getResource() method, forces the developer to use one and the
same pattern for their plugins and resources. That way, you can get into the
plugin code easily and modifications or bug-fixes can be done easier.
> Integrate jQuery UI integration into the Web Console Trunk
> ----------------------------------------------------------
>
> Key: FELIX-1988
> URL: https://issues.apache.org/jira/browse/FELIX-1988
> Project: Felix
> Issue Type: Task
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: webconsole-3.0.0
>
> Attachments: abstr-simple-web-console.patch, src.zip
>
>
> Valentin Valchev has implemented jQuery UI support in the web console. This
> issue is to keep track of this migration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
