On 2/16/10 8:33 PM, Richard S. Hall wrote:
On 2/16/10 8:21 PM, Carsten Ziegeler wrote:
Richard S. Hall wrote:
Why add the version explicitly? It automatically gets picked up by BND,
if we include it explicitly then we have to remember to change it when
the source package version changes...

No, it doesn't get picked up by bnd automatically. That's why I added it. :)
  And I guess if bnd would do so, it would use the version of the pom
which is different from the spec version.

Strange, I just built and it did. In the pom file:

<Export-Package>org.osgi.service.event</Export-Package>

In the resulting manifest file:

Export-Package: org.osgi.service.event;uses:="org.osgi.framework";vers
 ion="1.2"


You can see other examples of this, like in framework which uses BND to build its JAR, it doesn't specify versions and they all get included properly. BND looks in the packageinfo files to get the exported version.

-> richard

-> richard


Regards
Carsten

->  richard

On 2/16/10 5:31 PM, [email protected] wrote:
Author: cziegeler
Date: Tue Feb 16 09:31:47 2010
New Revision: 910444

URL: http://svn.apache.org/viewvc?rev=910444&view=rev
Log:
Add version information to export

Modified:
      felix/trunk/eventadmin/impl/pom.xml

Modified: felix/trunk/eventadmin/impl/pom.xml
URL:
http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=910444&r1=910443&r2=910444&view=diff

==============================================================================

--- felix/trunk/eventadmin/impl/pom.xml (original)
+++ felix/trunk/eventadmin/impl/pom.xml Tue Feb 16 09:31:47 2010
@@ -84,7 +84,7 @@
<!-- default -->
                               *
</Import-Package>
-<Export-Package>org.osgi.service.event</Export-Package>
+<Export-Package>org.osgi.service.event;version=1.2</Export-Package>

<Private-Package>org.apache.felix.eventadmin.impl.*</Private-Package>
<Import-Service>
                   org.osgi.service.event.EventHandler,
org.osgi.service.log.LogService, org.osgi.service.log.LogReaderService




Reply via email to