[
https://issues.apache.org/jira/browse/FELIX-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834836#action_12834836
]
David Savage commented on FELIX-2092:
-------------------------------------
There are a few HashSet's hanging around these have a tendency to chew up
memory rather quickly so I've now replaced them with arrays -
I'll bear the ArrayList suggestion in mind - may offer a good trade off between
memory and performance...with the patches I've made the code is now memory
efficient which was my initial goal as with large repos like the spring
enterprise repo this could lead to the ant or eclipse barfing
Using arrays I now have to create lists on demand for other parts of the code
so may be a bit less cpu efficient - though I'm using Arrays.asList that's
likely to get git compiled pretty quickly in most vm's I would guess
> Improve memory profile of model elements by using arrays and null objects vs
> HashSets to store parts of model
> -------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2092
> URL: https://issues.apache.org/jira/browse/FELIX-2092
> Project: Felix
> Issue Type: Improvement
> Components: Sigil
> Reporter: David Savage
> Assignee: David Savage
> Priority: Minor
> Fix For: sigil-1.0.0
>
>
> In large repositories the amount of meta data that is held in memory can
> cause OutOfMemoryErrors if an attempt is made to cache data
> Candidate patches for improving the profile include, BundleModelElement
> (imports, exports, requires) and AbstractModelElement.meta which are the main
> offenders according to YourKit analysis
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
