On Feb 28, 2010, at 4:03 PM, Karl Pauls wrote:
-1
I'm really sorry but it looks to me like:
org/apache/felix/karaf/deployer/features/FeatureURLHandler.java
org/apache/felix/karaf/shell/commands/EchoAction.java
Were these files in the first 1.4.0 release attempt? my rat scan
didn't find them.
are missing the license header and
manual/pom.xml
client/dependency-reduced-pom.xml
are missing a header as well. Furthermore,
org.apache.felix.karaf.deployer.spring and a lot of the other modules
have dependencies on spring-core which is not mentioned in the notice
nor in the overall src notice (its mentioned in the overall binary
notice).
AFAIK the legal requirements and best practice is that LICENSE and
NOTICE files are about what is actually in the artifact they are in,
not anything that might be needed to use the artifact. So unless a
karaf artifact actually includes code copied from spring, the NOTICE
files should not mention spring. Note that the maven-remote-resources-
plugin includes a dependencies report in the jar that lists the
dependencies and their licenses. Does felix have a different policy?
If so, why?
Other findings (not show-stoppers) are:
Signatures and checksums work for me but for some reason there are not
only .asc but .asc.asc and .asc.md5/sha and .asc.asc.md5/sha files
around. Very strange (probably something wrong with nexus/maven - not
sure we can do something about it).
AFAIK this is normal.
Other than that, it looks to me like you are only building the jars
and the sources jars but not the bin and project artifacts we usually
do. Not a problem as such (as you still have the sources for each
artifact) but its somewhat different from what we do normally ...
Is there a good reason for felix to do something other than the
defaults from the apache 7 pom? (not that karaf is)
thanks
david jencks
Some artifacts are still using the osgi jars from felix (they should
switch to use the official org.osgi artifacts as soon as possible).
regards,
Karl
On Wed, Feb 24, 2010 at 7:57 PM, Chris Custine <ccust...@apache.org>
wrote:
The Karaf 1.4.0 artifacts have been staged for release.
These release artifacts contain updated copyright year in all
NOTICE files
and includes an updated RELEASE-NOTES file which was not updated in
the
previous release vote. As requested by Richard, I have noted that
the vote
will be open for *at least* 72 hours in order to allow time for
proper
review.
Release notes are here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100&styleName=Html&version=12314410
Staging repository:
https://repository.apache.org/content/repositories/
orgapachefelix-015/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 015 /tmp/felix-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)
This vote will be open for at least 72 hours.
--
Chris Custine
FUSESource :: http://fusesource.com
My Blog :: http://blog.organicelement.com
Apache ServiceMix :: http://servicemix.apache.org
Apache Felix :: http://felix.apache.org
Apache Directory Server :: http://directory.apache.org
--
Karl Pauls
karlpa...@gmail.com
