[ 
https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844006#action_12844006
 ] 

Guillaume Nodet commented on FELIX-2176:
----------------------------------------

The code in PackageVersionAnalyzer compiles if you move the class to 
aQute.osgi.lib
It adds the bundle version to the private and exported packages if they don't 
have any version information yet.
The problem is that this happen only when using the manifest goal and not the 
bundle goal.
This discrepancy looks problematic to me, so I'm tempted to just remove that 
class and use the same manifest generation.
The version on exported packages can be easily added using:
   *;version="${project.version}"
instead of simply
   *


> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
>                 Key: FELIX-2176
>                 URL: https://issues.apache.org/jira/browse/FELIX-2176
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.1
>            Reporter: David Jencks
>             Fix For: maven-bundle-plugin-2.1.0
>
>         Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an 
> accessible private repo.  The bundle plugin can copy bnd into itself so users 
> don't have to have peter's secret stash configured in their nexus repo 
> manager.
> Patch does this and upgrades to latest bnd.  I can't see any reason to keep 
> the copied Builder source -- plugin passes tests and appears to work without 
> it -- so I removed it.  You'll need to run
> svn rm    src/main/java/aQute/lib/osgi/Builder.java
> Also the code in   
> src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java 
> _really_ doesn't compile any more and I suspect the functionality has moved 
> into bnd.  However I can't actually tell what its trying to do; I commented 
> it out.  If this functionality is actually in bnd then removing the class 
> would be a good idea.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to