[ 
https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844031#action_12844031
 ] 

Guillaume Nodet commented on FELIX-2173:
----------------------------------------

Done, though I'm not sure why we need those three classes, only for computing 
the version (I don't think the bundle symbolic name computation is really used 
in our case).
We only need a static method for that, not an interface, an implementation and 
a class.
I still plan to start a module for common osgi code (version range, version 
cleaning, etc...), that way, maven could reuse it if needed.

> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin 
> and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-2173
>                 URL: https://issues.apache.org/jira/browse/FELIX-2173
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>            Reporter: Graham Charters
>            Assignee: Guillaume Nodet
>             Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT 
> to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 
> 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily 
> coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when 
> used in other plugins or environments.  I think the 
> DefaultMaven2OsgiConverter  needs to be changed to match the maven bundle 
> plugin.
> See also: http://www.mail-archive.com/[email protected]/msg15894.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to